ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-04-13 15:57:14 +03:00
Code Issues Projects Releases Wiki Activity

Replaced write out checks with guard clauses

Browse Source 
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
This commit is contained in:
A_D 2020-07-13 06:32:55 +02:00 committed by Athanasius
parent 8268bfe5da
commit 1733aeae5a
1 changed files with 32 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
collate.py
View File

@ -65,18 +65,20 @@ def addcommodities(data):
commodities[key] = new
if len(commodities) > size_pre:
if isfile(commodityfile):
__make_backup(commodityfile)
if not len(commodities) > size_pre:
return
with open(commodityfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, ['id', 'symbol', 'category', 'name'])
writer.writeheader()
if isfile(commodityfile):
__make_backup(commodityfile)
for key in sorted(commodities):
writer.writerow(commodities[key])
with open(commodityfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, ['id', 'symbol', 'category', 'name'])
writer.writeheader()
print('Added {} new commodities'.format(len(commodities) - size_pre))
for key in sorted(commodities):
writer.writerow(commodities[key])
print('Added {} new commodities'.format(len(commodities) - size_pre))
# keep a summary of modules found
@ -124,18 +126,20 @@ def addmodules(data):
modules[key] = new
if len(modules) > size_pre:
if isfile(outfile):
__make_backup(outfile)
if not len(modules) > size_pre:
return
with open(outfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, fields, extrasaction='ignore')
writer.writeheader()
if isfile(outfile):
__make_backup(outfile)
for key in sorted(modules):
writer.writerow(modules[key])
with open(outfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, fields, extrasaction='ignore')
writer.writeheader()
print('Added {} new modules'.format(len(modules) - size_pre))
for key in sorted(modules):
writer.writerow(modules[key])
print('Added {} new modules'.format(len(modules) - size_pre))
# keep a summary of ships found
@ -175,19 +179,20 @@ def addships(data):
ships[key] = new
if len(ships) > size_pre:
if not len(ships) > size_pre:
return
if isfile(shipfile):
__make_backup(shipfile)
if isfile(shipfile):
__make_backup(shipfile)
with open(shipfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, ['id', 'symbol', 'name'])
writer.writeheader()
with open(shipfile, 'w') as csvfile:
writer = csv.DictWriter(csvfile, ['id', 'symbol', 'name'])
writer.writeheader()
for key in sorted(ships):
writer.writerow(ships[key])
for key in sorted(ships):
writer.writerow(ships[key])
print('Added {} new ships'.format(len(ships) - size_pre))
print('Added {} new ships'.format(len(ships) - size_pre))
if __name__ == "__main__":