From 2ac8026e3ea85fee7246538046884c0710cc751f Mon Sep 17 00:00:00 2001
From: Athanasius <Athanasius@miggy.org>
Date: Sun, 27 Nov 2022 17:01:28 +0000
Subject: [PATCH] eddn: Allow for `''` in `standard_header()`

`''` is Falsey, but a valid value, so we need an explicit `is not None`
test for these.
---
 plugins/eddn.py | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/plugins/eddn.py b/plugins/eddn.py
index 5921e19c..7e8bde96 100644
--- a/plugins/eddn.py
+++ b/plugins/eddn.py
@@ -989,12 +989,25 @@ class EDDN:
 
         :return: The standard header
         """
+        # We want to pass `''` sometimes, so can't just use a Truthiness test
+        if game_version is not None:
+            gv = game_version
+
+        else:
+            gv = this.game_version
+
+        if game_build is not None:
+            gb = game_build
+
+        else:
+            gb = this.game_build
+
         return {
             'softwareName':    f'{applongname} [{system() if sys.platform != "darwin" else "Mac OS"}]',
             'softwareVersion': str(appversion_nobuild()),
             'uploaderID':      this.cmdr_name,
-            'gameversion':     game_version or this.game_version,
-            'gamebuild':       game_build or this.game_build,
+            'gameversion':     gv,
+            'gamebuild':       gb,
         }
 
     def export_journal_generic(self, cmdr: str, is_beta: bool, entry: Mapping[str, Any]) -> None: