ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-04-15 08:40:34 +03:00
Code Issues Projects Releases Wiki Activity

EDMarketConnector: Use logger.trace_if(...)

Browse Source 
Yes, leaving that 'truncating plain logfile' as plain trace.
This commit is contained in:
Athanasius 2021-08-13 15:06:35 +01:00
parent 2754385281
commit 4433b67c82
No known key found for this signature in database
GPG Key ID: AE3E527847057C7D
2 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Contributing.md
View File

@ -416,13 +416,18 @@ In addition to that we utilise one of the user-defined levels as:
method provided on `logger`: method provided on `logger`:
```python ```python
logger.trace_if('my-trace-rule', 'my-log-message') logger.trace_if('journal.event.scan', 'my-log-message')
``` ```
The string used to identify this tracing should be related to the
**function of the code**, not the particular file, or class, that it is in.
This is so that the same string can be used to trace code that spans more
than one file, class, or other scope.
This would then be triggered by running EDMarketConnector with the This would then be triggered by running EDMarketConnector with the
appropriate command-line arguments: appropriate command-line arguments:
EDMarketConnector.py --trace-on my-trace-rule EDMarketConnector.py --trace-on journal.event.scan
Note that you do **not** also need to specify `--trace`, that's implied. Note that you do **not** also need to specify `--trace`, that's implied.

8
EDMarketConnector.py
View File

@ -174,7 +174,7 @@ if __name__ == '__main__': # noqa: C901
def handle_edmc_callback_or_foregrounding() -> None: # noqa: CCR001 def handle_edmc_callback_or_foregrounding() -> None: # noqa: CCR001
"""Handle any edmc:// auth callback, else foreground existing window.""" """Handle any edmc:// auth callback, else foreground existing window."""
logger.trace('Begin...') logger.trace_if('frontier-auth.windows', 'Begin...')
if platform == 'win32': if platform == 'win32':
@ -1108,7 +1108,7 @@ class AppWindow(object):
entry = monitor.get_entry() entry = monitor.get_entry()
if not entry: if not entry:
# This is expected due to some monitor.py code that appends `None` # This is expected due to some monitor.py code that appends `None`
# logger.trace('No entry from monitor.get_entry()') logger.trace_if('journal.queue', 'No entry from monitor.get_entry()')
return return
# Update main window # Update main window
@ -1199,7 +1199,7 @@ class AppWindow(object):
return # in CQC return # in CQC
if not entry['event'] or not monitor.mode: if not entry['event'] or not monitor.mode:
# logger.trace('Startup, returning') logger.trace_if('journal.queue', 'Startup, returning')
return # Startup return # Startup
if entry['event'] in ['StartUp', 'LoadGame'] and monitor.started: if entry['event'] in ['StartUp', 'LoadGame'] and monitor.started:
@ -1828,7 +1828,7 @@ sys.path: {sys.path}'''
ui_scale = 100 ui_scale = 100
config.set('ui_scale', ui_scale) config.set('ui_scale', ui_scale)
theme.default_ui_scale = root.tk.call('tk', 'scaling') theme.default_ui_scale = root.tk.call('tk', 'scaling')
logger.trace(f'Default tk scaling = {theme.default_ui_scale}') logger.trace_if('tk', f'Default tk scaling = {theme.default_ui_scale}')
theme.startup_ui_scale = ui_scale theme.startup_ui_scale = ui_scale
root.tk.call('tk', 'scaling', theme.default_ui_scale * float(ui_scale) / 100.0) root.tk.call('tk', 'scaling', theme.default_ui_scale * float(ui_scale) / 100.0)
app = AppWindow(root) app = AppWindow(root)