ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-04-17 17:42:20 +03:00
Code Issues Projects Releases Wiki Activity

Added type checker hint for unbound names

Browse Source 
Due to the fact that cmdr and entry are only assigned if item exists, a
situation can arise where any access to the names will raise an
UnboundLocalException, this tells the type checker to ignore that
possibility by using a TYPE_CHECKING guarded assignment to those names.

This does not fix the issue at runtime, it just tells the type checker
that its fine. As this remains a bug, I have left TODOs in to note its
existence.
This commit is contained in:
A_D 2020-08-25 12:00:30 +02:00
parent 7ab697a807
commit 62f3203c3f
No known key found for this signature in database
GPG Key ID: 4BE9EB7DF45076C4
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/edsm.py
View File

@ -468,13 +468,14 @@ def worker() -> None:
retrying = 0 retrying = 0
while retrying < 3: while retrying < 3:
try: try:
# TODO: Technically entry can be unbound here. if TYPE_CHECKING:
if item and entry['event'] in ('CarrierJump', 'FSDJump', 'Location', 'Docked'): # Tell the type checker that these two are bound.
logger.debug(f'{entry["event"]}') # TODO: While this works because of the item check below, these names are still technically unbound
# TODO: in some cases, therefore this should be refactored.
cmdr: str = ""
entry: Mapping[str, Any] = {}
if item and entry['event'] not in this.discardedEvents: if item and entry['event'] not in this.discardedEvents: # TODO: Technically entry can be unbound here.
if entry['event'] in ('CarrierJump', 'FSDJump', 'Location', 'Docked'):
logger.debug(f'{entry["event"]} event not in discarded list')
pending.append(entry) pending.append(entry)
# Get list of events to discard # Get list of events to discard