From 3ec9c81e192df088726266162846f44e5f92d9b0 Mon Sep 17 00:00:00 2001 From: Athanasius Date: Tue, 19 Oct 2021 16:01:54 +0100 Subject: [PATCH] EDDN: Drop any 'unknown schema' messages so they're not retried --- plugins/eddn.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/eddn.py b/plugins/eddn.py index 7e72aa0f..b4cd508d 100644 --- a/plugins/eddn.py +++ b/plugins/eddn.py @@ -298,7 +298,10 @@ Msg:\n{msg}''' if unknown_schema := self.UNKNOWN_SCHEMA_RE.match(e.response.text): logger.debug(f"EDDN doesn't (yet?) know about schema: {unknown_schema['schema_name']}" f"/{unknown_schema['schema_version']}") - # return # Pretend it went OK so this message isn't retried + # NB: This dropping is to cater for the time when EDDN + # doesn't *yet* support a new schema. + self.replaylog.pop(0) # Drop the message + self.flush() # Truncates the file, then writes the extant data else: status['text'] = self.http_error_to_log(e)