mirror of
https://github.com/EDCD/EDMarketConnector.git
synced 2025-04-12 15:27:14 +03:00
[Minor] Remove Deprecated Files and Functions
This commit is contained in:
parent
b8fedc84e4
commit
791a0c80c2
2
build.py
2
build.py
@ -76,10 +76,8 @@ def generate_data_files(
|
||||
"ChangeLog.md",
|
||||
"snd_good.wav",
|
||||
"snd_bad.wav",
|
||||
"modules.p", # TODO: Remove in 6.0
|
||||
"modules.json",
|
||||
"ships.json",
|
||||
"ships.p", # TODO: Remove in 6.0
|
||||
f"{app_name}.ico",
|
||||
f"resources/{appcmdname}.ico",
|
||||
"EDMarketConnector - TRACE.bat",
|
||||
|
@ -146,44 +146,3 @@ class HyperlinkLabel(sys.platform == 'darwin' and tk.Label or ttk.Label): # typ
|
||||
"""Copy the current text to the clipboard."""
|
||||
self.clipboard_clear()
|
||||
self.clipboard_append(self['text'])
|
||||
|
||||
|
||||
def openurl(url: str) -> None:
|
||||
r"""
|
||||
Open the given URL in appropriate browser.
|
||||
|
||||
2022-12-06:
|
||||
Firefox itself will gladly attempt to use very long URLs in its URL
|
||||
input. Up to 16384 was attempted, but the Apache instance this was
|
||||
tested against only allowed up to 8207 total URL length to pass, that
|
||||
being 8190 octets of REQUEST_URI (path + GET params).
|
||||
|
||||
Testing from Windows 10 Home 21H2 cmd.exe with:
|
||||
|
||||
"<path to>\firefox.exe" -osint -url "<test url>"
|
||||
|
||||
only allowed 8115 octest of REQUEST_URI to pass through.
|
||||
|
||||
Microsoft Edge yielded 8092 octets. Google Chrome yielded 8093 octets.
|
||||
|
||||
However, this is actually the limit of how long a CMD.EXE command-line
|
||||
can be. The URL was being cut off *there*.
|
||||
|
||||
The 8207 octet URL makes it through `webbrowser.open(<url>)` to:
|
||||
|
||||
Firefox 107.0.1
|
||||
Microsoft Edge 108.0.1462.42
|
||||
Google Chrome 108.0.5359.95
|
||||
|
||||
This was also tested as working *with* the old winreg/subprocess code,
|
||||
so it wasn't even suffering from the same limit as CMD.EXE.
|
||||
|
||||
Conclusion: No reason to not just use `webbrowser.open()`, as prior
|
||||
to e280d6c2833c25867b8139490e68ddf056477917 there was a bug, introduced
|
||||
in 5989acd0d3263e54429ff99769ff73a20476d863, which meant the code always
|
||||
ended up using `webbrowser.open()` *anyway*.
|
||||
:param url: URL to open.
|
||||
"""
|
||||
warnings.warn("This function is deprecated. "
|
||||
"Please use `webbrowser.open() instead.", DeprecationWarning, stacklevel=2)
|
||||
webbrowser.open(url)
|
||||
|
Loading…
x
Reference in New Issue
Block a user