From a9680ea8c06c71d30a82d1169e33c0400b7b33b5 Mon Sep 17 00:00:00 2001 From: Athanasius Date: Sun, 26 Jul 2020 22:34:15 +0100 Subject: [PATCH] Don't force --show-source in .flake8 ! This was the cause of our flake8-your-pr issue! It meant that as well as `--format json` giving JSON output it also got polluted with the raw string of the source line as well. --- .flake8 | 2 +- .github/workflows/pr-annotate-with-flake8.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.flake8 b/.flake8 index a762f8f7..03d0e79c 100644 --- a/.flake8 +++ b/.flake8 @@ -1,6 +1,6 @@ [flake8] # Show exactly where in a line the error happened -show-source = True +#show-source = True max-line-length = 120 # Add _ as a builtin for localisation stuff diff --git a/.github/workflows/pr-annotate-with-flake8.yml b/.github/workflows/pr-annotate-with-flake8.yml index 7ac9f99a..2f089a9d 100644 --- a/.github/workflows/pr-annotate-with-flake8.yml +++ b/.github/workflows/pr-annotate-with-flake8.yml @@ -24,6 +24,6 @@ jobs: with: python-version: 3.7 - name: Annotate with Flake8 - uses: "Athanasius/flake8-your-pr@master" + uses: "tayfun/flake8-your-pr@master" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}