Merge branch 'develop' into enhancement/2668/refactored-winsparklepy

.github/workflows/pr-checks.yml

@@ -100,7 +100,12 @@ jobs:
     ####################################################################
     # Ensure all tests pass
     ####################################################################
-    - name: PyTest tests
+    - name: Install Virtual Framebuffer Dependecies
       run: |
-        pytest
+        sudo apt-get update
+        sudo apt-get install -y xvfb python3-tk
+    
+    - name: Run Tests with Virtual Display
+      run: |
+        xvfb-run --auto-servernum pytest
     ####################################################################

tests/test_update.py

@@ -2,6 +2,7 @@
 # mypy: ignore-errors
 """Test the Updater."""
 
+import sys
 import pytest
 import pathlib
 import hashlib
@@ -144,12 +145,12 @@ class TestVersionChecking:
 
 
 class TestWinSparkleInit:
-    @patch("sys.platform", "win32")
+    @pytest.mark.skipif(sys.platform != "win32", reason="WinSparkle update logic is Windows-only")
-    @patch("ctypes.cdll.WinSparkle", create=True)
+    def test_winsparkle_init_success(self):
-    def test_winsparkle_init_success(self, mock_ws):
         """Verify WinSparkle initialization logic on Windows."""
-        with patch("update.get_update_feed", return_value="http://feed"):
+        with patch("ctypes.cdll.WinSparkle", create=True) as mock_ws:
-            with patch("update.appversion_nobuild", return_value="5.0.0"):
+            with patch("update.get_update_feed", return_value="http://feed"):
-                updater = update.Updater(provider="external")
+                with patch("update.appversion_nobuild", return_value="5.0.0"):
-                assert mock_ws.win_sparkle_init.called
+                    updater = update.Updater(provider="external")
-                assert mock_ws.win_sparkle_set_appcast_url.called
+                    assert mock_ws.win_sparkle_init.called
+                    assert mock_ws.win_sparkle_set_appcast_url.called