ED/EDMarketConnector
1
0
Fork 0
mirror of https://github.com/EDCD/EDMarketConnector.git synced 2025-06-19 16:24:07 +03:00
Code Issues Projects Releases Wiki Activity

JournalLock: No need to ' is True' on assert

Browse Source
This commit is contained in:
Athanasius 2021-03-25 11:03:35 +00:00
parent 0811a000ed
commit b6dcc39fb2
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/journal_lock.py/test_journal_lock.py
View File

@ -195,7 +195,7 @@ class TestJournalLock:
# Check that an actual journaldir is handled correctly. # Check that an actual journaldir is handled correctly.
locked = jlock.obtain_lock() locked = jlock.obtain_lock()
assert locked == JournalLockResult.LOCKED assert locked == JournalLockResult.LOCKED
assert jlock.locked is True assert jlock.locked
def test_obtain_lock_with_tmpdir_ro(self, mock_journaldir: py_path_local_LocalPath): def test_obtain_lock_with_tmpdir_ro(self, mock_journaldir: py_path_local_LocalPath):
"""Test JournalLock.obtain_lock() with read-only tmpdir.""" """Test JournalLock.obtain_lock() with read-only tmpdir."""
@ -296,19 +296,19 @@ class TestJournalLock:
# First actually obtain the lock, and check it worked # First actually obtain the lock, and check it worked
jlock = JournalLock() jlock = JournalLock()
jlock.obtain_lock() jlock.obtain_lock()
assert jlock.locked is True assert jlock.locked
# Now release the lock # Now release the lock
assert jlock.release_lock() is True assert jlock.release_lock()
# And finally check it actually IS unlocked. # And finally check it actually IS unlocked.
with open(mock_journaldir / 'edmc-journal-lock.txt', mode='w+') as lf: with open(mock_journaldir / 'edmc-journal-lock.txt', mode='w+') as lf:
assert _obtain_lock('release-lock', lf) is True assert _obtain_lock('release-lock', lf)
def test_release_lock_not_locked(self, mock_journaldir: py_path_local_LocalPath): def test_release_lock_not_locked(self, mock_journaldir: py_path_local_LocalPath):
"""Test JournalLock.release_lock() when not locked.""" """Test JournalLock.release_lock() when not locked."""
jlock = JournalLock() jlock = JournalLock()
assert jlock.release_lock() is True assert jlock.release_lock()
def test_release_lock_lie_locked(self, mock_journaldir: py_path_local_LocalPath): def test_release_lock_lie_locked(self, mock_journaldir: py_path_local_LocalPath):
"""Test JournalLock.release_lock() when not locked, but lie we are.""" """Test JournalLock.release_lock() when not locked, but lie we are."""
@ -332,14 +332,14 @@ class TestJournalLock:
# First actually obtain the lock, and check it worked # First actually obtain the lock, and check it worked
jlock = JournalLock() jlock = JournalLock()
jlock.obtain_lock() jlock.obtain_lock()
assert jlock.locked is True assert jlock.locked
# Now store the 'current' journaldir for reference and attempt # Now store the 'current' journaldir for reference and attempt
# to update to a new one. # to update to a new one.
old_journaldir = jlock.journal_dir old_journaldir = jlock.journal_dir
jlock.update_lock(None) # type: ignore jlock.update_lock(None) # type: ignore
assert jlock.journal_dir != old_journaldir assert jlock.journal_dir != old_journaldir
assert jlock.locked is True assert jlock.locked
def test_update_lock_same(self, mock_journaldir: py_path_local_LocalPath): def test_update_lock_same(self, mock_journaldir: py_path_local_LocalPath):
""" """
@ -351,11 +351,11 @@ class TestJournalLock:
# First actually obtain the lock, and check it worked # First actually obtain the lock, and check it worked
jlock = JournalLock() jlock = JournalLock()
jlock.obtain_lock() jlock.obtain_lock()
assert jlock.locked is True assert jlock.locked
# Now store the 'current' journaldir for reference and attempt # Now store the 'current' journaldir for reference and attempt
# to update to a new one. # to update to a new one.
old_journaldir = jlock.journal_dir old_journaldir = jlock.journal_dir
jlock.update_lock(None) # type: ignore jlock.update_lock(None) # type: ignore
assert jlock.journal_dir == old_journaldir assert jlock.journal_dir == old_journaldir
assert jlock.locked is True assert jlock.locked