From baac45f5fe7c793dd31467b7053798c7011d4bd7 Mon Sep 17 00:00:00 2001 From: Athanasius Date: Wed, 25 Aug 2021 14:54:53 +0100 Subject: [PATCH] CAPI: Some extra comments for fail/auth mess --- companion.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/companion.py b/companion.py index 2d6d6036..76ac3240 100644 --- a/companion.py +++ b/companion.py @@ -762,10 +762,13 @@ class Session(object): except (requests.HTTPError, ValueError) as e: logger.exception('Frontier CAPI Auth: GET ') self.dump(r) + # TODO: Does this *necessarily* mean we need to call close() ? + # Maybe the **CAPI** had a transitory issue and auth is fine. self.close() if self.retrying: # Refresh just succeeded but this query failed! Force full re-authentication logger.error('Frontier CAPI Auth: query failed after refresh') + # TODO: Again, this might be an auth issue, but maybe not. self.invalidate() self.retrying = False # TODO: This must NOT happen here, we need to signal back to the requesting