From ee12b2073c5f1b17c1e6435ba6f917274e0ff850 Mon Sep 17 00:00:00 2001 From: A_D Date: Wed, 9 Sep 2020 23:23:15 +0200 Subject: [PATCH] fixed some sentence construction --- Contributing.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Contributing.md b/Contributing.md index e6f82aea..80374301 100644 --- a/Contributing.md +++ b/Contributing.md @@ -194,9 +194,9 @@ and another for the Pull Request, merging or cherry-picking commits as needed. Yes, this means using 'color' rather than 'colour', and in general will mean US, not British, spellings. -## **ALWAYS** place a single-statement control flow body +## Control flow -e.g." control statements such as `if`, `else`, `for`, `foreach`, on a separate line, with consistent indentation. +Never oneline any control flow (`if`, `else`, `for`), as it makes spotting what happens next difficult. Yes: @@ -213,7 +213,9 @@ if something_true: one_thing_we_do() Yes, some existing code still flouts this rule. -### **Always** use Line breaks after scope changes. It makes reading code far easier +### Scope changes + +**Always** use Line breaks after scope changes. It makes seeing where scope has changed far easier on a quick skim Yes: