Confirmed by Snake Man on EDCD Discordin #edmc
Snake Man : looks ok I guess (never done much of these manual imports)
python3 trade.py import ../Daurtu.Panshin.Terminal.2019-09-12T12.29.27.prices
NOTE: Import complete: 93 updated items over 1 stations in 1 systems
Snake Man : trade.py market -vv daurtu/panshin command looks fine too. and trade.py run --cap 500 --cr 20m --ly 12 --fr daurtu/pans gives trading results, looks good indeed
Another str versus bytes issue. We *do* need the .encode('utf-8') in
this case, else it will assume Windows cp1252 encoding which then can't
encode some characters. So we switch to binary file mode instead.
*) Code and imports brought in line with edsy plugin
*) 'Coriolis' now appears in Settings > Configuration > Shipyard
dropdown
*) Confirmed that with this active a valid build opens on coriolis.io
This came to light due to python3 not liking try['StarPos'] =
list(this.coordinates) if this.coordinates was None. As the comment
says these three fields are mandatory, ensure we can actually set them
appropriately, and display an error if not.
NB: Due to, I assume, EDDN relay de-duplication of messages, it's been
difficult to 100% test this. No errors thrown, and stock/release EDMC
also doesn't result in a new message arriving at my EDDN consumer.
First pass utilising 'futurize' to do most of the work.
There's an issue with ur'\"' in l10n.py which I'm not sure how to
properly fix.
This now has errors when hitting the 'Update' button.
* Stores disable_autoappupdatecheckingame in settings.
* If 'disable' is active then once you're in-game WinSparkle auto
check for updates is disabled.
* Whatever the state of the option WinSparkle auto updates are
(re-)enabled when you exit the game to Main Menu or fully.
* Using 'Help' > 'Check for updates' manually will still always work.
It has been difficult to test the code fully because it isn't easy to
get WinSparkle's registry data about last update check time set just right
to not check immediately, but to do so some reasonable time after you're
in-game and have confirmed the new option setting isn't easy.
Worst case people won't learn about an update until the next time they
run EDMC.
