<https://github.com/EDCD/EDMarketConnector/issues/961>
It seems the game can report a Scan event *after* you've jumped to
another system. So don't blindly set StarPos on Scan, check the
SystemAddress against where we think we are first.
* Comment out the traceback in plugins/eddn.py, the return is enough.
* 'Called with no event_queue' can be TRACE.
* Don't care about "Everything was alright, the near-neutral status just
wasn't stored." from Inara.
The .values() is on this, so it also needs to be a dict.
I also made the logging of "FC or Damaged Station?" consistent
throughout this file.
Yes, we'll keep these as logger.debug() for now.
Very tight check on this to be sure we don't ignore other errors.
r.status_code == 400 # Not a different code
$schemaRef == commodities
The message had empty commodities list
r.text == expected return from EDDN Gateway
There are cases where a station/FC doesn't have outfitting modules or a
ships list. Let's make the checks happen in both those functions and be
extra paranoid with some logging.
Closes#671
* The logic for opening replay.jsonl, and detecting if the file was
already there or not was tortured. No longer.
* Changed a few logger.debug(..., exc_info=) to logger.exception().
* Changed all logger.warn() (deprecated) to logger.warning().
Generally for the logic cleanups it was replacing giant list
comprehensions with slightly smaller filter calls. filter() is just
plain cleaner when all you're doing in a list comp is
[x for x in y if somecondition].
Using:
from EDMarketConnector import logger
causes issues if EDMarketConnector is already importing 'this' file.
So just get a logger using logger.getLogger(appname) instead.
`from config import appname` if needs be.
The UI for setting the 'anonymous' option was removed in
f17f5d3f257e2359d4728ce8c296d70dc5e7609f ("PKCE OAuth2 access to cAPI").
Since then there's been no way for a user to set, or unset, this option
(and the associated custom uploaderID). However anyone with the registry keys
still set would have had them take effect.
This commit removes the last bits of code that were making use of it.
Note that the EDDN Relay anonymises all uploaderID values, so no listener
has been seeing the 'raw' values for a long time now.
close#575
