This came to light due to python3 not liking try['StarPos'] =
list(this.coordinates) if this.coordinates was None. As the comment
says these three fields are mandatory, ensure we can actually set them
appropriately, and display an error if not.
NB: Due to, I assume, EDDN relay de-duplication of messages, it's been
difficult to 100% test this. No errors thrown, and stock/release EDMC
also doesn't result in a new message arriving at my EDDN consumer.
First pass utilising 'futurize' to do most of the work.
There's an issue with ur'\"' in l10n.py which I'm not sure how to
properly fix.
This now has errors when hitting the 'Update' button.
* Stores disable_autoappupdatecheckingame in settings.
* If 'disable' is active then once you're in-game WinSparkle auto
check for updates is disabled.
* Whatever the state of the option WinSparkle auto updates are
(re-)enabled when you exit the game to Main Menu or fully.
* Using 'Help' > 'Check for updates' manually will still always work.
It has been difficult to test the code fully because it isn't easy to
get WinSparkle's registry data about last update check time set just right
to not check immediately, but to do so some reasonable time after you're
in-game and have confirmed the new option setting isn't easy.
Worst case people won't learn about an update until the next time they
run EDMC.
We need this in master so that the forthcoming Python 2.7 version that
detects plugins that aren't ready for migration can provide a link to
information about migrating. In the future the 'python3' branch might
have been removed.
To allow users to sort out their plugins before EDMC itself moves to
Python 3.x warn them if any of their enabled, non-stock, plugins do not
have a plugin_start3() method.
* If any are found without support there's a popup triggered at the
end of AppWindow initialisation.
* Then the user can check Settings > Plugins to see a list of the
plugins without Python 3.x support.
* Change instances of 'Marginal' to 'EDCD'. Including github URLs.
* Update SDKPATH and WIXPATH to the latest versions.
* Removes un-necessary attempt at including VCredist file. This isn't
needed on any Windows 10 version that is vaguely current (tested on
1909).
* Adds the following to the EDMarketConnector.wxs <Product Id ...>
section so that any new version definitely replaces any older one:
InstallScope="perMachine"
without this it defaults to a per-user install, and you end up with
the prior Marginal-era EDMC allegedly still installed as well, even
though they're installed into the same path.
See commit 1beca864d362625f983cc9465125124ffada4ae2 in the python3
branch.
* Appends ", 2020 Athanasius" to the copyright notices in setup.py.
This will likely change to ", 2020 EDCD" pending EDCD Council
approval.
This had been listing importlib_metadata, and its dependency zipp,
because it's a dependency of newer 'keyring'. As we're hard-coding an
older 'keyring' without that dependency we don't need to list them here.
