Athanasius
9259afd344
Add display of entire github context
2020-07-31 11:58:13 +01:00
Athanasius
c18f183db9
.git would be a directory if present, fix test
2020-07-29 15:00:39 +01:00
Athanasius
59babd113b
Just use the single allowed actor for now.
...
And it's now set to "Athanasius".
2020-07-29 15:00:39 +01:00
Athanasius
7a44c28b95
Revert "Try contains(['Athanasius'], github.actor)"
...
This reverts commit 72c201c5a1
2020-07-29 15:00:39 +01:00
Athanasius
e22fadd5f5
Revert "Set array in earlier job using JSON"
...
This reverts commit 8b863c5efd
2020-07-29 15:00:39 +01:00
Athanasius
51f92b3793
Revert "No nesting ${{..}}"
...
This reverts commit 9ed541f0e0
2020-07-29 15:00:39 +01:00
Athanasius
0736bbf97b
Revert "JSON must have double quotes"
...
This reverts commit 4db2c907df
2020-07-29 15:00:39 +01:00
Athanasius
069e7ce9e5
Revert "Wildcard on the end ?"
...
This reverts commit 511e7a48d6
2020-07-29 15:00:39 +01:00
Athanasius
9b2db0c2e2
Revert "Need at least one JSON key ?"
...
This reverts commit f509d974c1
2020-07-29 15:00:39 +01:00
Athanasius
ba437aecd3
Revert "We don't want 'matrix', just 'allowed'."
...
This reverts commit 9938370e91
2020-07-29 15:00:39 +01:00
Athanasius
c71d718c55
Revert "Maybe no wildcard now?"
...
This reverts commit 61898d1f91
2020-07-29 15:00:39 +01:00
Athanasius
dc8497cd9b
Maybe no wildcard now?
2020-07-29 15:00:39 +01:00
Athanasius
75947cb41b
We don't want 'matrix', just 'allowed'.
2020-07-29 15:00:39 +01:00
Athanasius
32190a6ebc
Need at least one JSON key ?
2020-07-29 15:00:39 +01:00
Athanasius
01354dc1ec
Wildcard on the end ?
2020-07-29 15:00:39 +01:00
Athanasius
d38c74d36a
JSON must have double quotes
2020-07-29 15:00:39 +01:00
Athanasius
52306b61b7
No nesting ${{..}}
2020-07-29 15:00:39 +01:00
Athanasius
5dd17cacae
Set array in earlier job using JSON
2020-07-29 15:00:39 +01:00
Athanasius
2375bf1995
Try contains(['Athanasius'], github.actor)
2020-07-29 15:00:39 +01:00
Athanasius
cea7d14214
Check for .git in PY files check.
...
NB: This might cause env.PYFILES checks to fail if they need the var
to at least exist.
2020-07-29 15:00:39 +01:00
Athanasius
a1e2344263
Invert the actor test
2020-07-29 15:00:39 +01:00
Athanasius
e3b01f6c58
Remove non-existent dependency
2020-07-29 15:00:39 +01:00
Athanasius
9f860a5990
Check if a conditional is needed on all steps
...
Basically, if it's only on the first and fails, then do the others
still run ?
2020-07-29 15:00:39 +01:00
Athanasius
912f82ce38
Needs a runs-on for the check_access
2020-07-29 15:00:39 +01:00
Athanasius
b40ee96755
Correct syntax
2020-07-29 15:00:39 +01:00
Athanasius
6c9bffcaa0
Don't run flake8_annotate if no access
...
This is using github.actor and checking who it is. If they're not
someone who should have access then use a run with 'exit 1' to fail the
check job.
Then flake8_annotate job needs check_access to have succeeded.
This *will* flag the workflow action as failed if no access, hopefully
it will be obvious why.
Using 'AthanasiusTEST' so it fails for me on this commit/push.
2020-07-29 15:00:39 +01:00
Athanasius
dc58d0f3af
S I N G L E Q U O T E S
2020-07-29 15:00:39 +01:00
Athanasius
09e39a47ef
Attempt to limit flake8 annotations to Athanasius
2020-07-29 15:00:39 +01:00
Athanasius
24cf445254
Gurantee exit 0 AND fix the echo
...
* GH Workflows run under "/bin/bash -e", which means if anything in it
fails it all exits immediately. So append " || true" to the egrep.
* The echo to magically set the env var back in the workflow needs to
use "" not '' else the in-shell variable won't interpolate.
2020-07-29 15:00:39 +01:00
Athanasius
40dc913367
*.py check should always exit 0
2020-07-29 15:00:39 +01:00
Athanasius
a548d383a3
Single quotes then ?
2020-07-29 15:00:39 +01:00
Athanasius
a93cfb5ed8
Try ENV var for passing presence of *.py files
...
This uses <https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions >
to set PYFILES env var globally in the job, so should be testable in
the following steps.
2020-07-29 15:00:39 +01:00
Athanasius
792583bfe1
*.py exit status was inverted
...
That'll teach me for testing with a commit only affecting *.yml files.
2020-07-29 15:00:39 +01:00
Athanasius
9c413a8ba9
Remove extraneous 'needs:'
2020-07-29 15:00:39 +01:00
Athanasius
dff1e3bce2
Do *.py check as step in flake8_annotate
...
And make both the 'Annotate with Flake8' and 'Set up Python 3.7' steps
dependent on it.
2020-07-29 15:00:39 +01:00
Athanasius
3ae0b83ac2
Only run flake8 annotation if there are *.py files in diff
2020-07-29 15:00:39 +01:00
Athanasius
629a3461f6
Final clean ups.
...
It works! So, yes, need refs/remotes/origin/ prepended to the base_ref,
which will always be a branch for a PR.
* Remove debug lines (set -x, etc).
* No need for pytest here as yet.
* Fall back to requirements.txt if no requirements-dev.txt.
2020-07-29 15:00:39 +01:00
Athanasius
648c1af339
See if prepending "refs/remotes/origin/" helps
2020-07-29 15:00:39 +01:00
Athanasius
f2fa489819
Attempt "git diff <branch> --"
...
As in "git diff [<options>] [<commit>] [--] [<path>...]", in case
it's an ambiguity rather than not knowing what 'develop' is.
2020-07-29 15:00:39 +01:00
Athanasius
4a965bb7c9
Extra git commands for diagnosis
2020-07-29 15:00:39 +01:00
Athanasius
3f97588ab6
Try "fetch-depth: 0" on the extra checkouts
2020-07-29 15:00:39 +01:00
Athanasius
18ff1c0e3f
Add 'set -x' to get feedback on all bash commands run
2020-07-29 15:00:39 +01:00
Athanasius
d36e213ae2
Correct "-name" -> "- name"
2020-07-29 15:00:39 +01:00
Athanasius
3ad8bd6cc8
pr-checks: Changed to pull_request and fleshed out
...
* Name all steps
* After checkout@v2 fetch: 1) checkout base_ref, 2) checkout head_ref
* Set and use BASE_REF env var
2020-07-29 15:00:39 +01:00
Athanasius
56e33d20d6
Copy push-checks.yml to pr-checks.yml
2020-07-29 15:00:39 +01:00
Athanasius
755e401df8
Revert "Change the push-checks back into also PRs."
...
This reverts commit 4da1d9df4e
2020-07-29 15:00:39 +01:00
Athanasius
4da1d9df4e
Change the push-checks back into also PRs.
...
Renamed to suit.
2020-07-28 13:45:55 +01:00
Athanasius
6ba1f77352
Remove greet-everyone workflow, we've gotten things working now
2020-07-26 23:04:37 +01:00
Athanasius
df3f70b7ed
Rename to push-checks.yml, don't do PRs
...
Also commented better at the top
2020-07-26 23:03:23 +01:00
Athanasius
6513db3aca
Don't force --show-source in .flake8 !
...
This was the cause of our flake8-your-pr issue! It meant that as well
as `--format json` giving JSON output it also got polluted with the raw
string of the source line as well.
2020-07-26 23:03:23 +01:00
Athanasius