Commit Graph
6677 Commits
Author SHA1 Message Date
Athanasius 837ac588cb Comments out py2exe in requirements-dev.txt as it trips up GitHub Actions
docs/Releasing.md has fuller instructions on getting that specific
pyexe version installed anyway.
2020-07-30 08:52:06 +01:00
Athanasius be6a7bcdc5 Releasing.md: Emphasises that sparkle:version is SemVer string. 2020-07-30 08:51:21 +01:00
Athanasius f849f010e2 Releasing.md: Update 'Known Issues' after a stable release. 2020-07-30 08:51:21 +01:00
A_D 8f7bd53b5c Fixed code blocks 2020-07-30 08:51:21 +01:00
A_D 7de06fb6ef Updated docs
Added linting, testing, and new requirements-dev.txt instructions
2020-07-30 08:51:21 +01:00
A_D aae4aace6c Create requirements-dev.txt 2020-07-30 08:51:21 +01:00
A_D 2fa49210d3 Removed dev deps from requirements.txt 2020-07-30 08:51:21 +01:00
A_D 536f2ff393 Add config for autopep8 2020-07-30 08:51:21 +01:00
A_D 26a94f247b Add flake8 and autopep8 to requirements.txt 2020-07-30 08:51:21 +01:00
Athanasius 9e18dde834 Update PLUGINS.md
Adds missing blank line that caused acciental underline/heading
2020-07-30 08:51:21 +01:00
Athanasius 3b87df17af Tweak EDMarketConnector.py startup so the redirect is first
* Don't want any output until the redirect is done when running frozen.
* Make the line buffering in the redirect more obvious.
2020-07-29 15:02:47 +01:00
Athanasius 4ecb4f573a 2 lines after def test_logging() 2020-07-29 15:02:47 +01:00
Athanasius 45ef87bcb4 Correct frame typing, and import clean up.
Also explains why we're doing that _getframe import that way.
2020-07-29 15:02:47 +01:00
Athanasius 589bc0b5f1 Cover all cases with inspect
* <module> works.
* top-level function in <module> works, presumably also any other file.
* Call from within classes works.
* Extra, commented out, test cases in EDMarketConnector.py
2020-07-29 15:02:47 +01:00
Athanasius 1989b272eb Use inspect to get frame information for qualname
Also includes some minor tweaks to make PyCharm happier:

* @classmethod caller_class_and_qualname().
* No need to () when "returning a tuple".
2020-07-29 15:02:47 +01:00
Athanasius 7a8f29edcf Add comments about future unit tests to implement.
Some of these won't even have been manually tested yet, so might require
more updates to the frame-walking function.
2020-07-29 15:02:47 +01:00
Athanasius a3b7dcbedc Logging: Handle 'bare function' caller for class/qualname 2020-07-29 15:02:47 +01:00
Athanasius c18f183db9 .git would be a directory if present, fix test 2020-07-29 15:00:39 +01:00
Athanasius 59babd113b Just use the single allowed actor for now.
And it's now set to "Athanasius".
2020-07-29 15:00:39 +01:00
Athanasius 7a44c28b95 Revert "Try contains(['Athanasius'], github.actor)"
This reverts commit 72c201c5a1.
2020-07-29 15:00:39 +01:00
Athanasius e22fadd5f5 Revert "Set array in earlier job using JSON"
This reverts commit 8b863c5efd.
2020-07-29 15:00:39 +01:00
Athanasius 51f92b3793 Revert "No nesting ${{..}}"
This reverts commit 9ed541f0e0.
2020-07-29 15:00:39 +01:00
Athanasius 0736bbf97b Revert "JSON must have double quotes"
This reverts commit 4db2c907df.
2020-07-29 15:00:39 +01:00
Athanasius 069e7ce9e5 Revert "Wildcard on the end ?"
This reverts commit 511e7a48d6.
2020-07-29 15:00:39 +01:00
Athanasius 9b2db0c2e2 Revert "Need at least one JSON key ?"
This reverts commit f509d974c1.
2020-07-29 15:00:39 +01:00
Athanasius ba437aecd3 Revert "We don't want 'matrix', just 'allowed'."
This reverts commit 9938370e91.
2020-07-29 15:00:39 +01:00
Athanasius c71d718c55 Revert "Maybe no wildcard now?"
This reverts commit 61898d1f91.
2020-07-29 15:00:39 +01:00
Athanasius dc8497cd9b Maybe no wildcard now? 2020-07-29 15:00:39 +01:00
Athanasius 75947cb41b We don't want 'matrix', just 'allowed'. 2020-07-29 15:00:39 +01:00
Athanasius 32190a6ebc Need at least one JSON key ? 2020-07-29 15:00:39 +01:00
Athanasius 01354dc1ec Wildcard on the end ? 2020-07-29 15:00:39 +01:00
Athanasius d38c74d36a JSON must have double quotes 2020-07-29 15:00:39 +01:00
Athanasius 52306b61b7 No nesting ${{..}} 2020-07-29 15:00:39 +01:00
Athanasius 5dd17cacae Set array in earlier job using JSON 2020-07-29 15:00:39 +01:00
Athanasius 2375bf1995 Try contains(['Athanasius'], github.actor) 2020-07-29 15:00:39 +01:00
Athanasius cea7d14214 Check for .git in PY files check.
NB: This might cause env.PYFILES checks to fail if they need the var
to at least exist.
2020-07-29 15:00:39 +01:00
Athanasius a1e2344263 Invert the actor test 2020-07-29 15:00:39 +01:00
Athanasius e3b01f6c58 Remove non-existent dependency 2020-07-29 15:00:39 +01:00
Athanasius 9f860a5990 Check if a conditional is needed on all steps
Basically, if it's only on the first and fails, then do the others
still run ?
2020-07-29 15:00:39 +01:00
Athanasius 912f82ce38 Needs a runs-on for the check_access 2020-07-29 15:00:39 +01:00
Athanasius b40ee96755 Correct syntax 2020-07-29 15:00:39 +01:00
Athanasius 6c9bffcaa0 Don't run flake8_annotate if no access
This is using github.actor and checking who it is.  If they're not
someone who should have access then use a run with 'exit 1' to fail the
check job.

Then flake8_annotate job needs check_access to have succeeded.

This *will* flag the workflow action as failed if no access, hopefully
it will be obvious why.

Using 'AthanasiusTEST' so it fails for me on this commit/push.
2020-07-29 15:00:39 +01:00
Athanasius dc58d0f3af S I N G L E Q U O T E S 2020-07-29 15:00:39 +01:00
Athanasius 09e39a47ef Attempt to limit flake8 annotations to Athanasius 2020-07-29 15:00:39 +01:00
Athanasius ed9a4cfe29 Revert "Cause EDMC.py to diff to check the detection"
This reverts commit 3b55a7a5de.
2020-07-29 15:00:39 +01:00
Athanasius 9a5884b57d Cause EDMC.py to diff to check the detection 2020-07-29 15:00:39 +01:00
Athanasius 24cf445254 Gurantee exit 0 AND fix the echo
* GH Workflows run under "/bin/bash -e", which means if anything in it
 fails it all exits immediately.  So append " || true" to the egrep.
* The echo to magically set the env var back in the workflow needs to
 use "" not '' else the in-shell variable won't interpolate.
2020-07-29 15:00:39 +01:00
Athanasius 40dc913367 *.py check should always exit 0 2020-07-29 15:00:39 +01:00
Athanasius a548d383a3 Single quotes then ? 2020-07-29 15:00:39 +01:00
Athanasius a93cfb5ed8 Try ENV var for passing presence of *.py files
This uses <https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions>
to set PYFILES env var globally in the job, so should be testable in
the following steps.
2020-07-29 15:00:39 +01:00