Commit Graph
41 Commits
Author SHA1 Message Date
dependabot[bot] 735f1bb846 build(deps): bump actions/checkout from 2 to 2.3.4
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v2.3.4)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 07:13:48 +00:00
dependabot[bot] d02ede356e build(deps): bump actions/setup-python from 2 to 2.2.2
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 2.2.2.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v2...v2.2.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 05:16:52 +00:00
Athanasius 06568aeb2e pr-checks: No 'with:' if the body is empty 2021-04-12 08:31:48 +01:00
Athanasius 51f5cc3a31 pr-checks: Try without setting checkout ref
Going to test this with new PR from Athanasius account, with a 'behind'
develop.
2021-04-12 08:31:48 +01:00
Athanasius ed8b573090 pr-checks: Use github.head.sha for checkout ref 2021-04-12 08:31:48 +01:00
Athanasius c599a486d6 Restore showing the github context 2021-04-12 08:31:48 +01:00
Athanasius c2fdd0a319 pr-checks: Try not changing options to actions/checkout@v2 2021-04-12 08:31:48 +01:00
Athanasius 34d4e72bc4 GitHub workflows: echo info about what we're git diff'ing
Whenever A_D does a PR the checks, for some unclear reason, also contain
'other' files causing unexpected flake8 output.

i.e. PR that changes only plugins/inara.py somehow "git diff .. | flake8"
such that flake8 complains about things in collate.py, coriolis.py,
loadout.py
2021-04-12 08:31:47 +01:00
Athanasius 180d5b0cb6 Bump Python 3.8 -> 3.9 in {pr,push}-checks.yml GH workflows
Closes #893
2021-04-01 14:45:50 +01:00
A_D 1c80578fef Fixed backwards pip install command 2021-04-01 14:45:45 +01:00
Athanasius c69cc77682 Added auto-annotation to both checks
This works based on telling github how to understand the flake8 output

# Conflicts:
#	.github/workflows/push-checks.yml
2021-04-01 14:45:45 +01:00
Athanasius 6600d1a78a GitHub Workflow: Update to Python 3.8 2021-04-01 14:45:12 +01:00
A_D 009ded50a1 Ensured PRs dont fail on doc lints 2020-09-09 23:05:59 +02:00
Athanasius 3dab0e9d91 Comment pr-check flake8, and don't --exit-zero the full check 2020-07-31 14:44:44 +01:00
Athanasius 64e6ad439c Try remote-add/fetch in separate step 2020-07-31 13:28:28 +01:00
Athanasius 8d7f91248d Oops, moved the 'steps:' line too 2020-07-31 13:18:46 +01:00
Athanasius 063a83b8e8 Move 'Show github context' to just before flake8
$GITHUB_EVENT_PATH wasn't set in the shell with it first.
2020-07-31 13:17:56 +01:00
Athanasius 71fa1dbcf6 Comment the 'add base remote and fetch it' 2020-07-31 13:15:52 +01:00
Athanasius 3d46f23fc7 Need svn_url, not url
'url' is api.github.com
2020-07-31 13:07:40 +01:00
Athanasius 895376c039 Try manually adding remote and fetching to get the refs
Also, add 'end' to 'Show github context'
2020-07-31 13:05:20 +01:00
Athanasius 62fe9deae7 repo.owner.login not repo.full_name 2020-07-31 12:57:44 +01:00
Athanasius e1a5a1f811 Top-level event key needs to be pull_request 2020-07-31 12:51:07 +01:00
Athanasius 7c00ddcebf We want github.context for the full info 2020-07-31 12:40:38 +01:00
Athanasius 2fa10b4a9e Correct setting of BASE_REPO 2020-07-31 12:35:54 +01:00
Athanasius c5d43a4ada Try a whole new method of referring to 'base', and checkout 'head' 2020-07-31 12:34:12 +01:00
Athanasius 92ea8943df Run 'Show github context' as first step 2020-07-31 12:21:32 +01:00
Athanasius a01c36f660 Correct "-run:" to "run:" 2020-07-31 12:20:12 +01:00
Athanasius 015a50d53f Fix small typo "-name" -> "- name" 2020-07-31 12:18:05 +01:00
Athanasius 43ae6dde61 Restore changes, draft status was to blame ? 2020-07-31 12:15:15 +01:00
Athanasius 91e07a62eb Revert pr-checks.yml to see if it runs again 2020-07-31 12:12:53 +01:00
Athanasius 5d7612b0db Move comment, was it stopping any steps from being defined? 2020-07-31 12:09:05 +01:00
Athanasius 9259afd344 Add display of entire github context 2020-07-31 11:58:13 +01:00
Athanasius 629a3461f6 Final clean ups.
It works!  So, yes, need refs/remotes/origin/ prepended to the base_ref,
which will always be a branch for a PR.

* Remove debug lines (set -x, etc).
* No need for pytest here as yet.
* Fall back to requirements.txt if no requirements-dev.txt.
2020-07-29 15:00:39 +01:00
Athanasius 648c1af339 See if prepending "refs/remotes/origin/" helps 2020-07-29 15:00:39 +01:00
Athanasius f2fa489819 Attempt "git diff <branch> --"
As in "git diff [<options>] [<commit>] [--] [<path>...]", in case
it's an ambiguity rather than not knowing what 'develop' is.
2020-07-29 15:00:39 +01:00
Athanasius 4a965bb7c9 Extra git commands for diagnosis 2020-07-29 15:00:39 +01:00
Athanasius 3f97588ab6 Try "fetch-depth: 0" on the extra checkouts 2020-07-29 15:00:39 +01:00
Athanasius 18ff1c0e3f Add 'set -x' to get feedback on all bash commands run 2020-07-29 15:00:39 +01:00
Athanasius d36e213ae2 Correct "-name" -> "- name" 2020-07-29 15:00:39 +01:00
Athanasius 3ad8bd6cc8 pr-checks: Changed to pull_request and fleshed out
* Name all steps
* After checkout@v2 fetch: 1) checkout base_ref, 2) checkout head_ref
* Set and use BASE_REF env var
2020-07-29 15:00:39 +01:00
Athanasius 56e33d20d6 Copy push-checks.yml to pr-checks.yml 2020-07-29 15:00:39 +01:00