A_D
783b3c5ce9
clarified docs
2020-07-24 13:45:17 +01:00
A_D
0b2b76a9f5
Replaced write out checks with guard clauses
...
Guard clauses reduce indentation and help when reading code as they
remove a variable and indentation level that the reader would otherwise
need to keep track of
2020-07-24 13:45:17 +01:00
A_D
05de5b557e
Removed repeated int(key)
...
With the previous formatting changes there is no reason to leave key as
possibly a string anywhere, as it was already being converted to an int
everywhere anyway
2020-07-24 13:45:17 +01:00
A_D
8856cec36f
Move file backup code to a method
...
It was repeated in various places and increased noise
2020-07-24 13:45:17 +01:00
A_D
c233fa5ff5
Refactor __main__ logic
...
Most of this is just de-pyramiding the code, removing else clauses that
are unneeded (or making the if such that the else is not needed).
Rationale is simple, every level of indentation adds more that the
reader needs to keep track of.
2020-07-24 13:45:17 +01:00
A_D
5583486589
replace list literals with tuples
...
Tuples ensure that this isnt changed at runtime
2020-07-24 13:45:17 +01:00
A_D
6b73161cae
Replace AssertionErrors with ValueError
...
AssertionError comes from `assert`s, using it for this doesn't make sense as we're complaining about values
2020-07-24 13:45:17 +01:00
A_D
a40b085303
replace modulo formatting with .format
2020-07-24 13:45:17 +01:00
A_D
ec6a09a06d
removed oneline statements
2020-07-24 13:45:17 +01:00
A_D
43ba47ddf9
shortened line
2020-07-24 13:45:17 +01:00
A_D
3df8a1f77b
added missing whitespace where needed
2020-07-24 13:45:17 +01:00
A_D
8cd6bf4b93
removed unused import
2020-07-24 13:45:17 +01:00
A_D
a38a2420df
Add newlines to separate scopes
...
Newlines between scope changes help you to not get lost when reading
source
2020-07-24 13:45:17 +01:00
Jonathan Harris
32c5cccce4
Fixes another binary versus string issue in collate.py
2020-06-21 16:33:37 +01:00
Jonathan Harris
3c46e8d5fa
All executable files invoked with #!/usr/bin/env python3
2020-06-21 16:28:30 +01:00
Athanasius
0da9667cdb
collate.py can be run stand-alone, update to 'env'-based first line
2020-06-21 16:23:01 +01:00
Athanasius
5beac17553
Fixes another binary versus string issue in collate.py
2020-06-21 16:23:01 +01:00
Athanasius
ddf2babaaa
Fixes up "EDMC.py -j" for python3
2020-06-21 16:23:01 +01:00
Athanasius
67708fd090
Initial work on getting the EDMC.py CLI to work under python3
...
*) Fix up print usage
*) cPickle -> cpickle
*) "EDMC.py -p <cmdr name>" appears to have never been properly
updated for multi-account support.
2020-06-21 16:23:01 +01:00
Athanasius
e7545e174f
Use .items() instead of .iteritems()
2020-06-21 16:23:00 +01:00
Jonathan Harris
5fac03203a
Handle Limpets
2018-12-28 03:32:35 +00:00
Jonathan Harris
f2bd931a84
Add missing 3.2 ships, modules & commoditites
2018-09-25 00:17:59 +01:00
Jonathan Harris
df944b0f6e
Add some new 2.4 modules
2017-10-03 12:10:02 -07:00
Jonathan Harris
c2a17e60ca
Collate commodities indexed by id and including symbolic name
...
Use collated info in export to older tools.
2017-09-23 12:58:53 +01:00
Jonathan Harris
e438ba216a
No longer collate average commodity prices
2017-09-13 15:40:41 +01:00
Jonathan Harris
f790468078
Move functions that manipulate API output
2016-11-19 17:21:39 +00:00
Jonathan Harris
633edd5381
Fix for offline collation
2016-10-26 02:19:16 +01:00
Jonathan Harris
133e2be102
Also collate module and ship symbolic IDs
2016-07-28 14:09:04 +01:00
Jonathan Harris
d6bb4f90ca
Correct some commodity categories
...
"Ion Distributor" and "Trinkets Of Hidden Fortune" - see https://github.com/EDCD/FDevIDs/pull/6
2016-07-08 00:33:45 +01:00
Jonathan Harris
0a88e3e0ab
Support for collating from JSON dump
2016-06-19 16:47:28 +01:00
Jonathan Harris
ad0e57a285
Add "entitlement" field to collation
2016-02-25 05:39:34 +00:00
Jonathan Harris
68d8e326e6
Collate using in-game ship names
2016-02-17 03:05:35 +00:00
Jonathan Harris
85cc0c7e42
Rename commodities.csv collection to commodity.csv
2016-01-28 12:32:26 +00:00
Jonathan Harris
b7ff8a2324
Also collect commodity IDs.
2016-01-28 12:32:26 +00:00
Jonathan Harris
6df3ab72e8
Also collect nominal average commodity prices.
2015-12-21 01:01:41 +00:00
Jonathan Harris
6c9c4c73a3
Add helper script for collating lists of seen commodities, modules and ships.
2015-12-05 02:50:53 +00:00
