From 22da12c999a3217f53ada95aad78aca9ea43068c Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Fri, 30 Dec 2011 17:08:01 +0100 Subject: [PATCH] console: fix debug messages for buffer objects It doesn't make sense to print the size of new buffer objects as the resize function does the same. We also currently access uninitialized memory here so it is useless anyway. Also move the message of the unref function to be consistent with other objects. Signed-off-by: David Herrmann --- src/console_cell.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/console_cell.c b/src/console_cell.c index 75c2180..b843558 100644 --- a/src/console_cell.c +++ b/src/console_cell.c @@ -212,13 +212,12 @@ int kmscon_buffer_new(struct kmscon_buffer **out, unsigned int x, if (!buf) return -ENOMEM; - log_debug("console: new buffer with size %ux%u\n", buf->size_x, - buf->size_y); - memset(buf, 0, sizeof(*buf)); buf->ref = 1; buf->sb_max = DEFAULT_SCROLLBACK; + log_debug("console: new buffer object\n"); + ret = kmscon_buffer_resize(buf, x, y); if (ret) goto err_free; @@ -250,8 +249,6 @@ void kmscon_buffer_unref(struct kmscon_buffer *buf) if (--buf->ref) return; - log_debug("console: destroying buffer object\n"); - for (iter = buf->sb_first; iter; ) { tmp = iter; iter = iter->next; @@ -263,6 +260,7 @@ void kmscon_buffer_unref(struct kmscon_buffer *buf) free(buf->current); free(buf); + log_debug("console: destroying buffer object\n"); } /*