norohind/kmscon
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

conf: make missing arguments or wrong arguments fatal

Browse Source 
It is not acceptable to start the applications with wrong parameters. A
typo must be corrected before starting the application so simply fail
loudly on errors.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
This commit is contained in:
David Herrmann 2012-08-11 20:56:41 +02:00
parent 5c13be3f1d
commit 28be382019
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/conf.c
View File

@ -299,6 +299,7 @@ int conf_parse_argv(int argc, char **argv)
} else if (c == ':') {
fprintf(stderr, "Missing argument for option %s\n",
argv[optind - 1]);
return -EFAULT;
} else if (c == '?') {
if (optopt)
fprintf(stderr, "Unknown argument -%c\n",
@ -306,6 +307,7 @@ int conf_parse_argv(int argc, char **argv)
else
fprintf(stderr, "Unknown argument %s\n",
argv[optind - 1]);
return -EFAULT;
} else if (c < 100000) {
for (i = 0; i < len; ++i) {
if (options[i].short_name == c) {
@ -353,8 +355,10 @@ int conf_parse_argv(int argc, char **argv)
} else {
def_argv[0] = getenv("SHELL") ? : _PATH_BSHELL;
conf_global.argv = def_argv;
if (optind != argc)
if (optind != argc) {
fprintf(stderr, "Unparsed remaining arguments\n");
return -EFAULT;
}
}
/* --debug implies --verbose */