xkb: add a TODO note to kbd_dev_reset stub

This is a small regression whereby starting kmscon with e.g. Caps Lock
already on, will not be reflected in the modifier mask. It's not
currently possible with xkbcommon.

Signed-off-by: Ran Benita <ran234@gmail.com>
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
This commit is contained in:
Ran Benita 2012-05-20 17:35:10 +03:00 committed by David Herrmann
parent 698d0fb95a
commit 6c8877e0a2

View File

@ -177,12 +177,11 @@ void kbd_dev_reset(struct kbd_dev *kbd, const unsigned long *ledbits)
struct xkb_state *state;
static const struct {
int led;
const char *indicator_name;
const char *name;
} led_names[] = {
{ LED_NUML, "Num Lock" },
{ LED_CAPSL, "Caps Lock" },
{ LED_SCROLLL, "Scroll Lock" },
{ LED_COMPOSE, "Compose" },
{ LED_NUML, XKB_LED_NAME_NUM },
{ LED_CAPSL, XKB_LED_NAME_CAPS },
{ LED_SCROLLL, XKB_LED_NAME_SCROLL },
};
if (!kbd)
@ -193,6 +192,13 @@ void kbd_dev_reset(struct kbd_dev *kbd, const unsigned long *ledbits)
for (i = 0; i < sizeof(led_names) / sizeof(*led_names); i++) {
if (!input_bit_is_set(ledbits, led_names[i].led))
continue;
/*
* TODO: Add support in xkbcommon for setting the led state,
* and updating the modifier state accordingly. E.g., something
* like this:
* xkb_state_led_name_set_active(state, led_names[i].led);
*/
}
(void)state;