From 8c64daa5dfb4c751cc4a0876e97d6ebc52855927 Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Sat, 23 Jun 2012 22:52:24 +0200 Subject: [PATCH] uterm: video_fbdev: test whether bpp is power of 8 I have never seen something different but lets be sure here and test for modulo-8. Signed-off-by: David Herrmann --- src/uterm_internal.h | 1 + src/uterm_video_fbdev.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/uterm_internal.h b/src/uterm_internal.h index 88627a3..d40170b 100644 --- a/src/uterm_internal.h +++ b/src/uterm_internal.h @@ -161,6 +161,7 @@ struct fbdev_display { size_t len; void *map; unsigned int stride; + unsigned int bpp; }; struct fbdev_video { diff --git a/src/uterm_video_fbdev.c b/src/uterm_video_fbdev.c index 5709bba..1218d0c 100644 --- a/src/uterm_video_fbdev.c +++ b/src/uterm_video_fbdev.c @@ -159,6 +159,12 @@ static int display_activate_force(struct uterm_display *disp, return -EFAULT; } + if (vinfo->bits_per_pixel % 8) { + log_error("device %s uses no power of 8 bpp: %u", + disp->fbdev.node, vinfo->bits_per_pixel); + return -EFAULT; + } + if (finfo->visual != FB_VISUAL_TRUECOLOR || vinfo->bits_per_pixel < 16) { log_error("device %s does not support true-color bpp >= 16", @@ -201,6 +207,7 @@ static int display_activate_force(struct uterm_display *disp, disp->fbdev.xres = vinfo->xres; disp->fbdev.yres = vinfo->yres; disp->fbdev.len = len; + disp->fbdev.bpp = vinfo->bits_per_pixel / 8; disp->fbdev.bufid = 0; disp->flags |= DISPLAY_ONLINE;