From cfca84f25061c0b0e473cb1d91695c5979aa423e Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Fri, 23 Mar 2012 16:42:04 +0100 Subject: [PATCH] vt: fix callback enum type We should use the enum type instead of plain "int" to be more verbose here. Signed-off-by: David Herrmann --- src/vt.h | 5 ++++- tests/test_console.c | 4 +++- tests/test_terminal.c | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/vt.h b/src/vt.h index f327e83..41e0573 100644 --- a/src/vt.h +++ b/src/vt.h @@ -42,7 +42,6 @@ #include "eloop.h" struct kmscon_vt; -typedef bool (*kmscon_vt_cb) (struct kmscon_vt *vt, int action, void *data); enum kmscon_vt_action { KMSCON_VT_ENTER, @@ -54,6 +53,10 @@ enum kmscon_vt_id { KMSCON_VT_NEW = -1, }; +typedef bool (*kmscon_vt_cb) (struct kmscon_vt *vt, + enum kmscon_vt_action action, + void *data); + int kmscon_vt_new(struct kmscon_vt **out, kmscon_vt_cb cb, void *data); void kmscon_vt_ref(struct kmscon_vt *vt); void kmscon_vt_unref(struct kmscon_vt *vt); diff --git a/tests/test_console.c b/tests/test_console.c index fc8ba36..2a5f5ad 100644 --- a/tests/test_console.c +++ b/tests/test_console.c @@ -192,7 +192,9 @@ static void sig_term(struct ev_signal *sig, int signum, void *data) terminate = 1; } -static bool vt_switch(struct kmscon_vt *vt, int action, void *data) +static bool vt_switch(struct kmscon_vt *vt, + enum kmscon_vt_action action, + void *data) { struct console *con = data; int ret; diff --git a/tests/test_terminal.c b/tests/test_terminal.c index 1015469..c9ccc22 100644 --- a/tests/test_terminal.c +++ b/tests/test_terminal.c @@ -139,7 +139,9 @@ static void activate_outputs(struct app *app) } } -static bool vt_switch(struct kmscon_vt *vt, int action, void *data) +static bool vt_switch(struct kmscon_vt *vt, + enum kmscon_vt_action action, + void *data) { struct app *app = data; int ret;