norohind/vanilla
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Implement Honeycomb tab listener more safely

Browse Source 
Dalvik complains about CompatHoneycomb in Gingerbread and below. Seems
harmless, but I'll fix it just to be safe.
This commit is contained in:
Christopher Eby 2012-02-21 03:22:24 -06:00
parent b5fedb6993
commit 026464754a
2 changed files with 24 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/org/kreed/vanilla/CompatHoneycomb.java
View File

@ -26,8 +26,8 @@ import android.app.ActionBar;
import android.app.ActionBar.Tab;
import android.app.Activity;
import android.app.FragmentTransaction;
import android.provider.MediaStore;
import android.net.Uri;
import android.provider.MediaStore;
import android.view.MenuItem;
import android.view.View;
import android.widget.ListView;
@ -35,26 +35,35 @@ import android.widget.ListView;
/**
* Framework methods only in Honeycomb or above go here.
*/
public class CompatHoneycomb implements ActionBar.TabListener {
/**
* The LibraryActivity to callback to when a tab is selected.
*/
private final LibraryActivity mActivity;
private CompatHoneycomb(LibraryActivity activity)
{
mActivity = activity;
}
public class CompatHoneycomb {
/**
* Add ActionBar tabs for LibraryActivity.
*
* @param activity The activity to add to.
*/
public static void addActionBarTabs(LibraryActivity activity)
public static void addActionBarTabs(final LibraryActivity activity)
{
ActionBar.TabListener listener = new ActionBar.TabListener() {
private final LibraryActivity mActivity = activity;
@Override
public void onTabReselected(Tab tab, FragmentTransaction ft)
{
}
@Override
public void onTabSelected(Tab tab, FragmentTransaction ft)
{
mActivity.mViewPager.setCurrentItem(tab.getPosition());
}
@Override
public void onTabUnselected(Tab tab, FragmentTransaction ft)
{
}
};
ActionBar ab = activity.getActionBar();
CompatHoneycomb listener = new CompatHoneycomb(activity);
ab.addTab(ab.newTab()
.setText(R.string.artists)
.setTabListener(listener));
@ -112,22 +121,6 @@ public class CompatHoneycomb implements ActionBar.TabListener {
ab.selectTab(ab.getTabAt(position));
}
@Override
public void onTabReselected(Tab tab, FragmentTransaction ft)
{
}
@Override
public void onTabSelected(Tab tab, FragmentTransaction ft)
{
mActivity.mViewPager.setCurrentItem(tab.getPosition());
}
@Override
public void onTabUnselected(Tab tab, FragmentTransaction ft)
{
}
/**
* Call {@link android.provider.MediaStore.Audio.Genres#getContentUriForAudioId(String,int)}
* on the external volume.

2
src/org/kreed/vanilla/LibraryPagerAdapter.java
View File

@ -78,7 +78,7 @@ public class LibraryPagerAdapter extends PagerAdapter implements Handler.Callbac
/**
* The playlist adapter instance, also stored at mAdapters[3].
*/
private MediaAdapter mPlaylistAdapter;
MediaAdapter mPlaylistAdapter;
/**
* The file adapter instance, also stored at mAdapters[5].
*/