From 3fd61bcafe33fe1d7b1d63dfd603fb3c5b373686 Mon Sep 17 00:00:00 2001 From: David Beswick Date: Thu, 21 Jul 2011 19:45:19 +1000 Subject: [PATCH] Playback is stopped immediately on song change before further processing, so the user has feedback on their input. Some operations in this method can cause a delay on my phone. --- src/org/kreed/vanilla/PlaybackService.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/org/kreed/vanilla/PlaybackService.java b/src/org/kreed/vanilla/PlaybackService.java index c9a25147..8b96f735 100644 --- a/src/org/kreed/vanilla/PlaybackService.java +++ b/src/org/kreed/vanilla/PlaybackService.java @@ -574,6 +574,10 @@ public final class PlaybackService extends Service implements Handler.Callback, if (mMediaPlayer == null) return; + synchronized (mMediaPlayer) { + mMediaPlayer.stop(); + } + Song song = mTimeline.shiftCurrentSong(delta); if (song == null) { if (Song.isSongAvailable())