From 5006744dbc427225c560d30e5daa3668bd61f214 Mon Sep 17 00:00:00 2001 From: Adrian Ulrich Date: Wed, 1 Nov 2017 19:45:49 +0100 Subject: [PATCH] fix crash on API < 21 ScheduledLibraryUpdate extends JobService which requires API >= 21. This causes older versions to crash at startup as the whole ScheduledLibraryUpdate class does not 'exist' on older devices. --- src/ch/blinkenlights/android/vanilla/PlaybackService.java | 4 +++- .../blinkenlights/android/vanilla/ScheduledLibraryUpdate.java | 4 ---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/ch/blinkenlights/android/vanilla/PlaybackService.java b/src/ch/blinkenlights/android/vanilla/PlaybackService.java index ae417177..60ef7d8e 100644 --- a/src/ch/blinkenlights/android/vanilla/PlaybackService.java +++ b/src/ch/blinkenlights/android/vanilla/PlaybackService.java @@ -517,7 +517,9 @@ public final class PlaybackService extends Service mAccelLast = SensorManager.GRAVITY_EARTH; setupSensor(); - ScheduledLibraryUpdate.scheduleUpdate(this); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + ScheduledLibraryUpdate.scheduleUpdate(this); + } } @Override diff --git a/src/ch/blinkenlights/android/vanilla/ScheduledLibraryUpdate.java b/src/ch/blinkenlights/android/vanilla/ScheduledLibraryUpdate.java index 4b854dda..490f3e15 100644 --- a/src/ch/blinkenlights/android/vanilla/ScheduledLibraryUpdate.java +++ b/src/ch/blinkenlights/android/vanilla/ScheduledLibraryUpdate.java @@ -27,7 +27,6 @@ import android.app.job.JobService; import android.content.Context; import android.content.ComponentName; import android.database.ContentObserver; -import android.os.Build; @TargetApi(21) @@ -50,9 +49,6 @@ public class ScheduledLibraryUpdate extends JobService { * @return true if job was scheduled, false otherwise */ public static boolean scheduleUpdate(Context context) { - if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) - return false; // JobScheduler requires API 21 - JobScheduler scheduler = (JobScheduler) context.getSystemService(Context.JOB_SCHEDULER_SERVICE); ComponentName componentName = new ComponentName(context, ScheduledLibraryUpdate.class);