norohind/vanilla
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Cancel the notification through updateState on service destruction

Browse Source 
The avoids a flicker to the paused notification if destroyed while playing
This commit is contained in:
Christopher Eby 2010-03-21 17:43:32 -05:00
parent 1d629c7fa2
commit 696e65a18a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/org/kreed/vanilla/PlaybackService.java
View File

@ -179,6 +179,7 @@ public class PlaybackService extends Service implements Runnable, MediaPlayer.On
saveState(true);
if (mMediaPlayer != null) {
mSongTimeline = null;
updateState(STATE_NORMAL);
mMediaPlayer.release();
mMediaPlayer = null;
@ -189,7 +190,6 @@ public class PlaybackService extends Service implements Runnable, MediaPlayer.On
} catch (IllegalArgumentException e) {
// we haven't registered the receiver yet
}
mNotificationManager.cancel(NOTIFICATION_ID);
if (mWakeLock != null && mWakeLock.isHeld())
mWakeLock.release();
@ -499,7 +499,7 @@ public class PlaybackService extends Service implements Runnable, MediaPlayer.On
private boolean updateNotification(Song song)
{
if (song == null || !mNotifyWhilePaused && mState == STATE_NORMAL) {
if (song == null || !mNotifyWhilePaused && mState == STATE_NORMAL || mState == STATE_NO_MEDIA) {
if (mNotificationManager != null)
mNotificationManager.cancel(NOTIFICATION_ID);
return true;