Use holo-style background for buttons

res/drawable/close.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/close_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/close_focused" />
-	<item android:drawable="@drawable/close_normal" />
-</selector>

res/drawable/hidden_next.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/next_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/next_focused" />
+	<item android:state_pressed="true" android:drawable="@drawable/next" />
+	<item android:state_focused="true" android:drawable="@drawable/next" />
 	<item android:drawable="@drawable/empty" />
 </selector>

res/drawable/hidden_pause.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/pause_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/pause_focused" />
+	<item android:state_pressed="true" android:drawable="@drawable/pause" />
+	<item android:state_focused="true" android:drawable="@drawable/pause" />
 	<item android:drawable="@drawable/empty" />
 </selector>

res/drawable/hidden_play.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/play_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/play_focused" />
+	<item android:state_pressed="true" android:drawable="@drawable/play" />
+	<item android:state_focused="true" android:drawable="@drawable/play" />
 	<item android:drawable="@drawable/empty" />
 </selector>

res/drawable/list_selector_background_transition_holo_dark.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright (C) 2010 The Android Open Source Project
+
+     Licensed under the Apache License, Version 2.0 (the "License");
+     you may not use this file except in compliance with the License.
+     You may obtain a copy of the License at
+
+          http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing, software
+     distributed under the License is distributed on an "AS IS" BASIS,
+     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     See the License for the specific language governing permissions and
+     limitations under the License.
+-->
+<transition xmlns:android="http://schemas.android.com/apk/res/android">
+	<item android:drawable="@drawable/list_pressed_holo_dark"  />
+	<item android:drawable="@drawable/list_longpressed_holo"  />
+</transition>

res/drawable/next.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/next_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/next_focused" />
-	<item android:drawable="@drawable/next_normal" />
-</selector>

res/drawable/pause.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/pause_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/pause_focused" />
-	<item android:drawable="@drawable/pause_normal" />
-</selector>

res/drawable/play.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/play_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/play_focused" />
-	<item android:drawable="@drawable/play_normal" />
-</selector>

res/drawable/previous.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:state_pressed="true" android:drawable="@drawable/previous_focused" />
-	<item android:state_focused="true" android:drawable="@drawable/previous_focused" />
-	<item android:drawable="@drawable/previous_normal" />
-</selector>

res/drawable/selectable_item_bg.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright (C) 2010 The Android Open Source Project
+
+     Licensed under the Apache License, Version 2.0 (the "License");
+     you may not use this file except in compliance with the License.
+     You may obtain a copy of the License at
+
+          http://www.apache.org/licenses/LICENSE-2.0
+
+     Unless required by applicable law or agreed to in writing, software
+     distributed under the License is distributed on an "AS IS" BASIS,
+     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     See the License for the specific language governing permissions and
+     limitations under the License.
+-->
+<selector xmlns:android="http://schemas.android.com/apk/res/android" android:exitFadeDuration="@android:integer/config_mediumAnimTime">
+
+	<item android:state_window_focused="false" android:drawable="@android:color/transparent" />
+
+	<!-- Even though these two point to the same resource, have two states so the drawable will invalidate itself when coming out of pressed state. -->
+	<item android:state_focused="true"  android:state_enabled="false" android:state_pressed="true" android:drawable="@drawable/list_selector_disabled_holo_dark" />
+	<item android:state_focused="true"  android:state_enabled="false"                              android:drawable="@drawable/list_selector_disabled_holo_dark" />
+	<item android:state_focused="true"                                android:state_pressed="true" android:drawable="@drawable/list_selector_background_transition_holo_dark" />
+	<item android:state_focused="false"                               android:state_pressed="true" android:drawable="@drawable/list_selector_background_transition_holo_dark" />
+	<item android:state_focused="true"                                                             android:drawable="@drawable/list_focused_holo" />
+</selector>

res/layout-v11/notification.xml

@@ -64,7 +64,7 @@ THE SOFTWARE.
 		android:layout_gravity="center"
 		android:background="?android:attr/selectableItemBackground"
 		android:scaleType="fitCenter"
-		android:src="@drawable/play_normal"
+		android:src="@drawable/play"
 		android:contentDescription="@string/play_pause" />
 	<ImageButton
 		android:id="@+id/next"
@@ -75,7 +75,7 @@ THE SOFTWARE.
 		android:layout_gravity="center"
 		android:background="?android:attr/selectableItemBackground"
 		android:scaleType="fitCenter"
-		android:src="@drawable/next_normal"
+		android:src="@drawable/next"
 		android:contentDescription="@string/next_song" />
 	<ImageButton
 		android:id="@+id/close"

res/layout/actionbar_controls.xml

@@ -22,7 +22,7 @@ THE SOFTWARE.
 -->
 <org.kreed.vanilla.ActionBarControls
 	xmlns:android="http://schemas.android.com/apk/res/android"
-	android:background="?android:attr/selectableItemBackground"
+	android:background="@drawable/selectable_item_bg"
 	android:clickable="true">
 	<ImageView
 		android:id="@+id/cover"

res/layout/controls.xml

@@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+Copyright (C) 2012 Christopher Eby <kreed@kreed.org>
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+-->
+<merge xmlns:android="http://schemas.android.com/apk/res/android">
+	<ImageButton
+		android:id="@+id/shuffle"
+		android:layout_height="fill_parent"
+		android:layout_width="0px"
+		android:layout_weight="1"
+		android:background="@drawable/selectable_item_bg"
+		android:scaleType="fitCenter"
+		android:src="@drawable/shuffle_inactive"
+		android:contentDescription="@string/cycle_shuffle_mode" />
+	<ImageButton
+		android:id="@+id/previous"
+		android:layout_height="fill_parent"
+		android:layout_width="0px"
+		android:layout_weight="1"
+		android:background="@drawable/selectable_item_bg"
+		android:scaleType="fitCenter"
+		android:src="@drawable/previous"
+		android:contentDescription="@string/previous_song" />
+	<ImageButton
+		android:id="@+id/play_pause"
+		android:layout_height="fill_parent"
+		android:layout_width="0px"
+		android:layout_weight="1"
+		android:background="@drawable/selectable_item_bg"
+		android:scaleType="fitCenter"
+		android:src="@drawable/play"
+		android:contentDescription="@string/play_pause" />
+	<ImageButton
+		android:id="@+id/next"
+		android:layout_height="fill_parent"
+		android:layout_width="0px"
+		android:layout_weight="1"
+		android:background="@drawable/selectable_item_bg"
+		android:scaleType="fitCenter"
+		android:src="@drawable/next"
+		android:contentDescription="@string/next_song" />
+	<ImageButton
+		android:id="@+id/end_action"
+		android:layout_height="fill_parent"
+		android:layout_width="0px"
+		android:layout_weight="1"
+		android:background="@drawable/selectable_item_bg"
+		android:scaleType="fitCenter"
+		android:src="@drawable/repeat_inactive"
+		android:contentDescription="@string/cycle_repeat_mode" />
+</merge>

res/layout/four_long_widget.xml

@@ -78,7 +78,7 @@ THE SOFTWARE.
 			android:layout_weight="1"
 			android:src="@drawable/play"
 			android:padding="5dip"
-			android:background="@null"
+			android:background="@drawable/selectable_item_bg"
 			android:scaleType="centerInside"
 			android:contentDescription="@string/play_pause" />
 		<ImageButton
@@ -89,7 +89,7 @@ THE SOFTWARE.
 			android:layout_weight="1"
 			android:padding="5dip"
 			android:src="@drawable/next"
-			android:background="@null"
+			android:background="@drawable/selectable_item_bg"
 			android:scaleType="centerInside"
 			android:contentDescription="@string/next_song" />
 	</LinearLayout>

res/layout/full_playback.xml

@@ -62,50 +62,6 @@ THE SOFTWARE.
 		android:layout_margin="0dip"
 		android:background="#a000"
 		android:orientation="horizontal">
-		<ImageButton
-			android:id="@+id/shuffle"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/shuffle_inactive"
-			android:contentDescription="@string/cycle_shuffle_mode" />
-		<ImageButton
-			android:id="@+id/previous"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/previous"
-			android:contentDescription="@string/previous_song" />
-		<ImageButton
-			android:id="@+id/play_pause"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/play"
-			android:contentDescription="@string/play_pause" />
-		<ImageButton
-			android:id="@+id/next"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/next"
-			android:contentDescription="@string/next_song" />
-		<ImageButton
-			android:id="@+id/end_action"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/repeat_inactive"
-			android:contentDescription="@string/cycle_repeat_mode" />
+		<include layout="@layout/controls" />
 	</LinearLayout>
 </merge>

res/layout/full_playback_alt.xml

@@ -94,50 +94,6 @@ THE SOFTWARE.
 		android:layout_margin="0dip"
 		android:background="#a000"
 		android:orientation="horizontal">
-		<ImageButton
-			android:id="@+id/shuffle"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/shuffle_inactive"
-			android:contentDescription="@string/cycle_shuffle_mode" />
-		<ImageButton
-			android:id="@+id/previous"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/previous"
-			android:contentDescription="@string/previous_song" />
-		<ImageButton
-			android:id="@+id/play_pause"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/play"
-			android:contentDescription="@string/play_pause" />
-		<ImageButton
-			android:id="@+id/next"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/next"
-			android:contentDescription="@string/next_song" />
-		<ImageButton
-			android:id="@+id/end_action"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/repeat_inactive"
-			android:contentDescription="@string/cycle_repeat_mode" />
+		<include layout="@layout/controls" />
 	</LinearLayout>
 </merge>

res/layout/library_content.xml

@@ -21,7 +21,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 -->
 <LinearLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+	xmlns:android="http://schemas.android.com/apk/res/android"
 	android:id="@+id/content"
 	android:orientation="vertical"
 	android:layout_width="fill_parent"
@@ -32,11 +32,11 @@ THE SOFTWARE.
 		android:layout_height="0px"
 		android:layout_weight="1" />
 	<HorizontalScrollView
-	    android:id="@+id/limiter_scroller"
-	    android:layout_width="fill_parent"
+		android:id="@+id/limiter_scroller"
+		android:layout_width="fill_parent"
 		android:layout_height="wrap_content"
 		android:layout_gravity="bottom|left">
-	    <LinearLayout
+		<LinearLayout
 			android:id="@+id/limiter_layout"
 			android:layout_width="wrap_content"
 			android:layout_height="fill_parent" />
@@ -64,7 +64,7 @@ THE SOFTWARE.
 			android:paddingBottom="4dip"
 			android:layout_width="wrap_content"
 			android:layout_height="fill_parent"
-			android:background="@null"
+			android:background="@drawable/selectable_item_bg"
 			android:src="@drawable/close"
 			android:contentDescription="@string/clear_search" />
 	</LinearLayout>

res/layout/library_controls.xml

@@ -64,51 +64,7 @@ THE SOFTWARE.
 			android:orientation="horizontal"
 			android:layout_width="fill_parent"
 			android:layout_height="fill_parent">
-			<ImageButton
-				android:id="@+id/shuffle"
-				android:layout_height="fill_parent"
-				android:layout_width="0px"
-				android:layout_weight="1"
-				android:background="@null"
-				android:scaleType="fitCenter"
-				android:src="@drawable/shuffle_inactive"
-				android:contentDescription="@string/cycle_shuffle_mode" />
-			<ImageButton
-				android:id="@+id/previous"
-				android:layout_height="fill_parent"
-				android:layout_width="0px"
-				android:layout_weight="1"
-				android:background="@null"
-				android:scaleType="fitCenter"
-				android:src="@drawable/previous"
-				android:contentDescription="@string/previous_song" />
-			<ImageButton
-				android:id="@+id/play_pause"
-				android:layout_height="fill_parent"
-				android:layout_width="0px"
-				android:layout_weight="1"
-				android:background="@null"
-				android:scaleType="fitCenter"
-				android:src="@drawable/play"
-				android:contentDescription="@string/play_pause" />
-			<ImageButton
-				android:id="@+id/next"
-				android:layout_height="fill_parent"
-				android:layout_width="0px"
-				android:layout_weight="1"
-				android:background="@null"
-				android:scaleType="fitCenter"
-				android:src="@drawable/next"
-				android:contentDescription="@string/next_song" />
-			<ImageButton
-				android:id="@+id/end_action"
-				android:layout_height="fill_parent"
-				android:layout_width="0px"
-				android:layout_weight="1"
-				android:background="@null"
-				android:scaleType="fitCenter"
-				android:src="@drawable/repeat_inactive"
-				android:contentDescription="@string/cycle_repeat_mode" />
+			<include layout="@layout/controls" />
 		</LinearLayout>
 	</LinearLayout>
 </LinearLayout>

res/layout/mini_playback.xml

@@ -36,50 +36,6 @@ THE SOFTWARE.
 		android:layout_height="wrap_content"
 		android:layout_width="match_parent"
 		android:orientation="horizontal">
-		<ImageButton
-			android:id="@+id/shuffle"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/shuffle_inactive"
-			android:contentDescription="@string/cycle_shuffle_mode" />
-		<ImageButton
-			android:id="@+id/previous"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/previous"
-			android:contentDescription="@string/previous_song" />
-		<ImageButton
-			android:id="@+id/play_pause"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/play"
-			android:contentDescription="@string/play_pause" />
-		<ImageButton
-			android:id="@+id/next"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/next"
-			android:contentDescription="@string/next_song" />
-		<ImageButton
-			android:id="@+id/end_action"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/repeat_inactive"
-			android:contentDescription="@string/cycle_repeat_mode" />
+		<include layout="@layout/controls" />
 	</LinearLayout>
 </LinearLayout>

res/layout/widget_e.xml

@@ -53,55 +53,6 @@ THE SOFTWARE.
 		android:orientation="horizontal"
 		android:layout_width="fill_parent"
 		android:layout_height="wrap_content">
-		<ImageButton
-			android:id="@+id/shuffle"
-			android:adjustViewBounds="true"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/shuffle_inactive"
-			android:contentDescription="@string/cycle_shuffle_mode" />
-		<ImageButton
-			android:id="@+id/previous"
-			android:adjustViewBounds="true"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/previous"
-			android:contentDescription="@string/previous_song" />
-		<ImageButton
-			android:id="@+id/play_pause"
-			android:adjustViewBounds="true"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/play"
-			android:contentDescription="@string/play_pause" />
-		<ImageButton
-			android:id="@+id/next"
-			android:adjustViewBounds="true"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/next"
-			android:contentDescription="@string/next_song" />
-		<ImageButton
-			android:id="@+id/end_action"
-			android:adjustViewBounds="true"
-			android:layout_height="fill_parent"
-			android:layout_width="0px"
-			android:layout_weight="1"
-			android:background="@null"
-			android:scaleType="fitCenter"
-			android:src="@drawable/repeat_inactive"
-			android:contentDescription="@string/cycle_repeat_mode" />
+		<include layout="@layout/controls" />
 	</LinearLayout>
 </LinearLayout>

res/xml/preferences.xml

@@ -71,7 +71,7 @@ THE SOFTWARE.
 			android:defaultValue="false" />
 	</PreferenceCategory>
 	<PreferenceCategory android:title="@string/pref_playback_view">
-	    <CheckBoxPreference
+		<CheckBoxPreference
 			android:key="playback_on_startup"
 			android:title="@string/playback_on_startup_title"
 			android:summary="@string/playback_on_startup_summary"

src/org/kreed/vanilla/PlaybackService.java

@@ -1660,7 +1660,7 @@ public final class PlaybackService extends Service
 		String title = song.title;
 
 		if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
-			int playButton = playing ? R.drawable.pause_normal : R.drawable.play_normal;
+			int playButton = playing ? R.drawable.pause : R.drawable.play;
 			views.setImageViewResource(R.id.play_pause, playButton);
 
 			ComponentName service = new ComponentName(this, PlaybackService.class);

src/org/kreed/vanilla/PlaylistAdapter.java

@@ -77,7 +77,7 @@ public class PlaylistAdapter extends CursorAdapter implements Handler.Callback {
 
 		Resources res = context.getResources();
 		mDragBitmap = BitmapFactory.decodeResource(res, R.drawable.grabber);
-		mDeleteBitmap = BitmapFactory.decodeResource(res, R.drawable.close_normal);
+		mDeleteBitmap = BitmapFactory.decodeResource(res, R.drawable.close);
 	}
 
 	/**