From c0854e27400b884f01a69bc202360b05aa2c72bb Mon Sep 17 00:00:00 2001 From: Adrian Ulrich Date: Fri, 3 Feb 2017 21:36:10 +0100 Subject: [PATCH] fix setSortMode range check Modes are inverted indexes, so we can not use Math.abs() --- src/ch/blinkenlights/android/vanilla/MediaAdapter.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ch/blinkenlights/android/vanilla/MediaAdapter.java b/src/ch/blinkenlights/android/vanilla/MediaAdapter.java index e7f465a5..7ef12125 100644 --- a/src/ch/blinkenlights/android/vanilla/MediaAdapter.java +++ b/src/ch/blinkenlights/android/vanilla/MediaAdapter.java @@ -560,9 +560,10 @@ public class MediaAdapter * is negative, the inverse of the index will be used and sort order will * be reversed. */ - public void setSortMode(int i) + public void setSortMode(int mode) { - mSortMode = (Math.abs(i) < mSortEntries.length ? i : 0); + int index = ( mode < 0 ? ~mode : mode); // 'negative' modes are actually inverted indexes + mSortMode = index < mSortEntries.length ? mode : 0; } /**