norohind/vanilla
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Avoid race during fragment creation

Browse Source 
onTimelineChanged() is not always called on creation, but setSong() is
This commit is contained in:
Adrian Ulrich 2016-03-28 13:14:44 +02:00
parent 62d83dbf32
commit f4cbd1053e
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/ch/blinkenlights/android/vanilla/ShowQueueFragment.java
View File

@ -72,7 +72,9 @@ public class ShowQueueFragment extends Fragment
public void onResume() {
super.onResume();
// Check if playback service has already been created
// Get playback service if we can and must
// This happens eg. during a rotate where the view
// was destroyed
if (mService == null && PlaybackService.hasInstance())
mService = PlaybackService.get(getActivity());
@ -210,11 +212,25 @@ public class ShowQueueFragment extends Fragment
mListView.setSelectionFromTop(currentSongPosition, 0); /* scroll to currently playing song */
}
// Used Callbacks of TImelineCallback
public void onTimelineChanged() {
if (mService == null)
/**
* Called after a song has been set.
* We are only interested in this call if mService is null
* as this signals that the playback service just became ready
* (and wasn't during onResume())
*/
public void setSong(long uptime, Song song) {
if (mService == null) {
mService = PlaybackService.get(getActivity());
refreshSongQueueList(false);
onTimelineChanged();
}
}
/**
* Called after the timeline changed
*/
public void onTimelineChanged() {
if (mService != null)
refreshSongQueueList(false);
}
// Unused Callbacks of TimelineCallback
@ -226,8 +242,6 @@ public class ShowQueueFragment extends Fragment
}
public void replaceSong(int delta, Song song) {
}
public void setSong(long uptime, Song song) {
}
public void setState(long uptime, int state) {
}
}