140 Commits

Author SHA1 Message Date
Adrian Ulrich
aaa5f8e3ef Do not hardcode path to /sdcard 2019-09-08 17:49:24 +02:00
Toby Hsieh
789e0d181c Move Details before Delete in LibraryActivity's FancyMenu (#969)
This makes it more consistent with the FancyMenu for tracks in the
queue, where Details appears before Remove.
2019-08-02 10:06:30 +02:00
wchen342
ef22a8cb46 Fix a bug in https://github.com/vanilla-music/vanilla/pull/935. (#962) 2019-06-09 08:59:30 +02:00
Adrian Ulrich
fa8cb5a975 Blacklist 'Android/media' by default 2019-05-22 13:21:21 +02:00
Adrian Ulrich
209b1b2cc7 add more debug info 2019-05-01 18:35:51 +02:00
Adrian Ulrich
c57d256a1c Take R128 header (not) into account while calculating replay gain. 2019-05-01 18:15:31 +02:00
Adrian Ulrich
6ab52195b5 fix fingerprint calculation.
The '+' operation takes precedence over the shift, so the code was shifting the type by hashCode bits, which is obviously wrong.
2019-03-29 20:18:39 +01:00
E.Wings
646e6e3362 Fixed back button behavior in Setting-Audio (#935) 2019-03-19 21:08:12 +01:00
Kanedias
50d8d43b54 Simplify plugin package search. Fix plugin detection. (#926)
Currently plugin searching still works in two stages, first it searches
for all plugin broadcast receivers and then waits for all the answers
to complete the plugin map. If any of plugins doesn't answer the call
this means all of them won't be shown and that's not very user-friendly.

The change simplifies plugin search to just package scan for specific
broadcast receivers. Android provides package name and app info for it.
We don't need any other info from plugins, so we don't need to wait for
broadcast roadtrip.

Further improvements:
* introduce meta-data and uses-feature tags in
plugin manifests and get rid of broadcast receiver completely.
* Implement view in settings activity with list of installed plugins
2019-02-28 21:30:26 +01:00
newhinton
0b3c1ef5d8 Remove onOptionsItemSelected to fix backbutton in settings (#921) 2019-02-28 19:08:34 +01:00
Petko Ditchev
e0d0936001 Fix relative path resolution (#928)
When you have a music folder /music and a playlists folder /music/playlists , then reading a playlist with a song ../a.mp3 inside resolved to "/music/playlists/../a.mp3" , which broke the import operation. Using getCanonicalPath instead of getAbsolutePath fixes the issue, since the former resolves the URI to /music/a.mp3
2019-02-28 19:03:42 +01:00
Adrian Ulrich
16dd5fc601 only apply gain correction if we have any R128 tags. 2019-02-21 20:10:42 +01:00
Adrian Ulrich
2340a349a1 add flags to MatrixCursor 2019-02-21 19:42:36 +01:00
Adrian Ulrich
a7c3943e07 Select FLAGS in full playlist projection 2019-02-18 19:44:33 +01:00
Adrian Ulrich
94bb87a210 Use U+00B7 in queue view. 2019-02-17 15:30:00 +01:00
Adrian Ulrich
1a6c9018e1 keep track of absent album or artist tags and do not display covers for unknown albums. 2019-02-17 15:26:21 +01:00
Adrian Ulrich
915c5851f3 Fix R128 replay gain
The old calculation was always wrong if there was a base value.
2019-02-17 15:04:28 +01:00
Adrian Ulrich
2145666183 sync with bastp head 2019-02-17 14:12:35 +01:00
Adrian Ulrich
fa9847b4d0 Use U+00B7 as separator 2019-02-12 08:22:06 +01:00
Adrian Ulrich
1240325f80 Use WORD SEPARATOR MIDDLE DOT instead of EN-DASH 2019-02-11 08:24:36 +01:00
Adrian Ulrich
4d074d52ad shor duration of playlists 2019-02-10 19:53:55 +01:00
Adrian Ulrich
9ce0975d41 migrate to androidx 2019-02-09 11:59:55 +01:00
Edontin
9f65fb3f84 [Issue #905] Add playlist path relativization option. (#908)
* Add playlist path relativization option.

Allows relative paths to be specified/exported within synchronized playlists.

* Minor code clean up for relative playlist exports.

Removes some unnecessary code and slightly improves associated Javadocs.
2019-02-03 09:31:53 +01:00
Adrian Ulrich
e312d41874 support 'play all' for files adapter 2019-02-02 20:20:35 +01:00
Adrian Ulrich
18abc9e97a Set theme for BottomSheet 2019-01-27 13:12:09 +01:00
Adrian Ulrich
7443ae3179 replace dialogplus with bottomsheet 2019-01-27 11:34:26 +01:00
Adrian Ulrich
7540c5c38e use dialogplus 2019-01-26 12:16:22 +01:00
Michael Sam
3bb0998d76 add helper for shared preference to organize code more (#901)
* add helper for shared preference to organize code more

* requested changes to pull request #901
-add the usual copyright / license boilerplate to SharedPrefHelper.
-edit the comment on method getSettings in SharedPrefHelper

* requested changes to pull request #901
-add the usual copyright / license boilerplate to SharedPrefHelper.
-edit the comment on method getSettings in SharedPrefHelper
2019-01-26 09:25:10 +01:00
Adrian Ulrich
b72f1ed832 Only jump to song if we found it AFTER the currently playing item. 2019-01-21 20:23:24 +01:00
Adrian Ulrich
f1b7d241fe make jump-to-enqueued-song an option 2019-01-02 11:51:28 +01:00
Adrian Ulrich
c7605a58d5 Adjust how we draw 'text below cover' bitmaps 2019-01-02 11:00:53 +01:00
Adrian Ulrich
b812373d5d Use three lines for FullPlaybackActivity's separateds bitmap view 2018-12-29 21:14:52 +01:00
Adrian Ulrich
ba2f722698 adjust cover padding 2018-12-29 20:42:01 +01:00
Antic1tizen One
4210a9ece0 Speedup plugin search, add quick plugin button (#887)
We are now fully switched to activity-based plugin
start system, so we don't need to start service or
wake activity anymore. Delete relevant part.

If the additiona; information is needed about the
plugin we can dig it out from its broadcast receiver.

Also, add quick "Plugins" button to the full playback
activity so there are only 2 clicks away from any plugin.
2018-12-28 10:17:26 +01:00
Jitnaught
e6df2ed2ba Fix MediaScanner incorrectly handling empty/whitespace title/album/artist/disc number (#886)
* Fixed media scanner not correctly handling empty or whitespace title/album/artist/disc number.

* Moved string unset check to function.
2018-12-28 10:14:55 +01:00
Adrian Ulrich
92a23a09d5 Fix song.hashCode() to work on Android 4.x devices.
Older android releases do not implement java.lang.Long.hashCode.
2018-12-11 20:17:02 +01:00
Adrian Ulrich
17920a5103 do not compare song object by reference 2018-12-10 20:04:35 +01:00
Adrian Ulrich
7fe09ad005 override hashCode and equals for song object 2018-12-10 20:04:25 +01:00
Adrian Ulrich
e997ac9207 Set notifyForDescendants to true.
This is needed for newer api versions to make contentObserver work.
2018-12-03 22:01:55 +01:00
Adrian Ulrich
66bebc8709 move seek bar to bottom 2018-12-03 21:56:00 +01:00
Adrian Ulrich
9e23dfce15 report whether we consumed the event, so we don't need to lie to the parent view 2018-12-03 20:29:11 +01:00
Adrian Ulrich
873674232c do not enforce height on Holo 2018-11-25 17:06:51 +01:00
Adrian Ulrich
7ffd0169b3 patch DragSortListView to support setOnTouchListener calls.
This enables users of a DSLV to call setOnTouchListener without breaking the drag functionality.
2018-11-25 14:42:09 +01:00
Adrian Ulrich
597d704e4e Have the popup menu overlap its parent 2018-11-24 21:12:24 +01:00
Adrian Ulrich
bad663761a fix horizontal calculation 2018-11-24 20:45:03 +01:00
Adrian Ulrich
f8fd73999e improve size calculation 2018-11-24 20:33:09 +01:00
Adrian Ulrich
89b110e5ea Improve listview measurement 2018-11-24 20:14:11 +01:00
Adrian Ulrich
82d8b7cccd use coordclicklistener in all places 2018-11-22 21:15:08 +01:00
Adrian Ulrich
715b80044f Make fancymenu a ListPopupWindow 2018-11-22 21:07:34 +01:00
Dmitri Davydok
eea0e444db Add stop to allowed actions. (#874) 2018-11-21 20:32:42 +01:00