norohind/vanilla
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity
2,034 Commits 2 Branches 0 Tags
Commit Graph

102 Commits

Author SHA1 Message Date
Adrian Ulrich
ce9ccd9bd4 Unregister sharedpreferences listener on destroy. 
If the playback service is stopped before the main activity gets killed, this would have caused the old class to still get updates.

Sending preference updates to such an orphaned PlaybackService would trigger crashes in some cases (especially when MediaLibrary detects suspicious unregisters).
 2018-10-14 19:44:51 +02:00
Antic1tizen One
e2598806ac No smooth scroll if user doesn't see it. Fixes vanilla-music/vanilla#844 (#847) 
The change adds interactive check to see if smooth scroll is actually
needed. If user doesn't see the library screen there's no point in
doing smooth scroll.

Besides, for old Android versions (like 4.x)
View.getFirstVisiblePosition, View.getLastVisiblePosition calls are
working only if view is currently visible.
 2018-10-13 12:13:57 +02:00
Adrian Ulrich
12824fd47b make enterSleepState() synchronized. 
There are a few crashes in the play store where the framework complains that we are underlocked.
Maybe this races with onDestroy() in some rare cases.
 2018-10-13 09:42:52 +02:00
Adrian Ulrich
8e607cb242 target 1.0.73 2018-09-29 10:50:06 +02:00
Antic1tizen One
45b6063515 Update plugin waking code, fix crash on Oreo devices (#840) 
* Update plugin waking code, fix crash on Oreo devices

In Android Oreo we can't use services without bringing them to the
foreground, i.e. showing icon and following specified lifecycle.

After some consideration the new way was implemented for plugin system.
Plugins will no longer have bound service and instead will do everything
required from within their activities. All background logic that
previously resided in services will now be performed before the activity
has even shown its window. This greatly reduces complexity and cost
associated with bringing service model in accordance with Oreo
guidelines. The only downside to this approach is small flickering
or pause in emulators as activities still expect to show themselves
on start instead of disappearing again.

* Move value to class-level constant
 2018-09-29 10:47:47 +02:00
Adrian Ulrich
fca6f14ab2 target 1.0.72 2018-08-29 18:01:11 +02:00
Adrian Ulrich
4bd4fb700a Really fix file picker. 2018-08-26 16:47:22 +02:00
Dmitri Davydok
3f0c7bb7a3 Implement some of the features present in Google Play Music: (#804) 
report the current song's position in the queue to the remote control;
report the current song's playback position to the remote control.
 2018-08-21 21:04:06 +02:00
Adrian Ulrich
90325aaf36 target 1.0.71 2018-08-21 07:32:18 +02:00
Adrian Ulrich
ad7a220423 update translations 2018-08-21 07:30:47 +02:00
Antic1tizen One
2fdac736b3 Scroll the queue only when the requested song is not on screen (#812) 
Now if the option "scroll to the queue position" is enabled and
a user is selecting a song in queue it immediately disappears from under
the finger and jumps to the top of currently visible list.

This patch fixes this behaviour - only scroll if next (or previous) song
falls out of list view visible range. I.e. sudden scrolling will never
happen if user clicks an item in queue as it's currently visible.
 2018-08-20 21:23:55 +02:00
Adrian Ulrich
e07fcc768b Fix file picker 
We swapped the 'recursive' flag, shamecube.
 2018-08-20 21:21:36 +02:00
Adrian Ulrich
5f9d91e9e7 target 1.0.70 2018-08-11 10:18:21 +02:00
Adrian Ulrich
240e8d6de6 update translations 2018-08-11 10:15:33 +02:00
Adrian Ulrich
d0fbb0eed0 Add minor PlaylistObserver bugfixes. 
* use mHandler.quit() on lower API versions
* do not trust filesystem version of playlists if folder is not writable
* disable debug logger
 2018-08-11 10:14:10 +02:00
Adrian Ulrich
480df8e99a use setSong() callback in scrolling 2018-08-06 19:49:38 +02:00
Adrian Ulrich
ed77cc8196 update translations 2018-08-05 12:43:49 +02:00
minus
a44d959716 Add option to scroll to new track on song change (#802) 
Adds a new setting to scroll the queue to the new song after a song
change. The new song will be at the top of the view.
 2018-08-05 11:01:46 +02:00
Adrian Ulrich
0a9297a16c disable playlist sync by default 2018-08-04 08:55:46 +02:00
Ub1Catcrush
317641bc30 A patch to add support for covers stored in the media files ID3Tag. (#796) 
* A patch to add support for covers stored in the media files IDTag.

* implement some suggested changes

* implement review comments
 2018-07-21 17:53:20 +02:00
Adrian Ulrich
4e3c440f80 Make playlist folder a config option 2018-07-15 21:01:41 +02:00
Adrian Ulrich
a8f84d85b4 Add dependency support to ListPreferenceSummary. 
Disable dependent views if value is "0".
 2018-07-15 20:36:08 +02:00
Adrian Ulrich
068352505c Do not import M3U if no metadata exists 2018-07-15 19:45:07 +02:00
Adrian Ulrich
b6fc1b8e31 Do not write EXTM3U 2018-07-09 19:40:22 +02:00
Adrian Ulrich
6992342f15 Make buildFileQuery more flexible. 
Add 'recursive' parameter, giving the caller the choice between an exact or recursive match.
 2018-07-09 19:38:37 +02:00
Adrian Ulrich
3234c46581 disable proguard in release builds 2018-07-07 12:03:27 +02:00
Thomas Hines
2354f7ee3a Included song title, ablum and artist in broadcast even when there is no Android media ID for the track. (#791) 2018-07-07 11:14:30 +02:00
Adrian Ulrich
b957b49e72 Add new PlaylistObserver which deprecates PlaylistBridge 2018-07-07 11:13:16 +02:00
Adrian Ulrich
92c4273a5e Add PLAYLIST_SYNC_MODE pref keys 2018-07-07 10:46:57 +02:00
Adrian Ulrich
5fbad4b5dd add M3U debug-dump function 2018-07-06 22:40:48 +02:00
Adrian Ulrich
629f0e0b8d Add LibraryObserver.Values.* 2018-07-06 22:18:39 +02:00
Adrian Ulrich
474402c119 fix NPE in DraggableRow 
line1 might be null for whatever reason (playlist with deleted songs during scan) - use placeholder text
for line1 if it is not a string object.
 2018-07-06 21:05:08 +02:00
Adrian Ulrich
f48ed019c7 Report affected playlists in removeFromPlaylist 2018-07-06 21:00:51 +02:00
Adrian Ulrich
e01117fb55 introduce playlist-observer metadata 2018-07-03 12:29:08 +02:00
Adrian Ulrich
4715bd3c31 implement simple m3u writer 2018-07-02 20:49:28 +02:00
Adrian Ulrich
eba6acabc2 introduce PlaylistObserver 2018-06-30 10:32:21 +02:00
TacoTheDank
dd40e45cbd stable build.gradle (#788) 
* Update build.gradle

* Update gradle-wrapper.properties

* Update gradle-wrapper.properties

* Update build.gradle

* Update .travis.yml

* Update gradle-wrapper.properties
 2018-06-30 09:30:52 +02:00
Adrian Ulrich
0c51c89d22 share Paint between onDraw calls 2018-06-28 22:05:56 +02:00
Adrian Ulrich
c3fff75a03 set allowBackup to true in manifest 
This enables full backups on SDK23 if enabled by the user.
 2018-06-28 21:50:34 +02:00
Adrian Ulrich
29e0e2cfc4 lint: use layout_height with wrap_content 2018-06-28 21:43:58 +02:00
Adrian Ulrich
f1f656ebb8 remove hardcoded /sdcard reference 2018-06-28 21:41:20 +02:00
Adrian Ulrich
11dde262ee Replace ContentObserver with own LibraryObserver class 2018-06-25 20:49:12 +02:00
Adrian Ulrich
34ef6893d2 target 1.0.62 2018-06-24 13:47:14 +02:00
Adrian Ulrich
8035b6c6fc make expand_or_play_all the default library action 2018-06-21 08:12:09 +02:00
Adrian Ulrich
f816592255 yet another icon attempt 2018-06-17 18:23:31 +02:00
Adrian Ulrich
be41eab712 a new day, a new adaptive icon! 2018-06-16 16:09:53 +02:00
Adrian Ulrich
bd9676c139 fix back button behavior 2018-06-16 16:08:33 +02:00
Adrian Ulrich
54414e1a4f Fix menu in portrait mode. 
SlidingView can now report why it is expanded, so the code is able to judge whether or not any UI elements are overlayd by the slide
 2018-06-16 15:44:51 +02:00
Adrian Ulrich
4c927d49fb remove sdk versions from manifest 
This is now done by gradle.
 2018-06-06 21:15:14 +02:00
Adrian Ulrich
ef0d852b05 Add horizontal layout 2018-06-04 21:18:05 +02:00