Commit Graph
129 Commits
Author SHA1 Message Date
Adrian Ulrich fae1f7207b add fancymanu to playlist activity 2018-11-12 10:57:34 +01:00
Adrian Ulrich 5e39f5ceec Add FancyMenu to ShowQueueFragment 2018-11-12 10:41:23 +01:00
Adrian Ulrich 893e96cbd4 add 'remove' drawable 2018-11-12 10:11:52 +01:00
Adrian Ulrich 77f48a00f5 update icons 2018-11-12 09:45:07 +01:00
Toby Hsieh 7c92c27336 Add FOREGROUND_SERVICE permission (#867)
Since 7c9731e05b targets API 28, playing a
song will crash on Android 9 unless we declare this permission.

See https://developer.android.com/about/versions/pie/android-9.0-changes-28#fg-svc
2018-11-12 08:41:59 +01:00
Adrian Ulrich 1d11f64e9e tune fancymenu layout 2018-11-02 21:10:02 +01:00
Adrian Ulrich 0df0328eef Add menu drawables 2018-11-02 20:49:52 +01:00
Adrian Ulrich 62ea38873a ...aaand also add layouts for fancymenu. 2018-11-01 20:56:26 +01:00
Adrian Ulrich 5a0fd2b538 Introduce FancyMenu.
A menu-item like menu which gives us better layout control.
2018-11-01 20:55:32 +01:00
Adrian Ulrich 885618ef36 redo text at bottom layout 2018-10-27 19:02:26 +02:00
Adrian Ulrich 2afbfcb90f Avoid crash if empty is label (no genre) 2018-10-27 11:18:34 +02:00
Adrian Ulrich 7c9731e05b upgrade API level 28. 2018-10-27 11:14:57 +02:00
Adrian Ulrich 779d418a9d disable add-to-homescreen for files 2018-10-27 10:50:47 +02:00
Adrian Ulrich 20962e37d0 Reorganise context menu 2018-10-26 22:17:30 +02:00
Adrian Ulrich 4ac874d4de support for legacy devices 2018-10-26 21:24:06 +02:00
Adrian Ulrich 62e498a1a9 initial shortcut support 2018-10-26 20:20:15 +02:00
Adrian Ulrich e37225bb91 update translations 2018-10-24 20:42:13 +02:00
Adrian Ulrich 1364754980 allow to stort albums by duration 2018-10-24 20:41:15 +02:00
Adrian Ulrich 13fff22d0c Check full native media library if startNormalScan() is called.
Make library scans more agressive, even if we not scan the full filesystem.

This is only invoked by background scheduler scans OR user triggered actions.
The quickscan will still only check the library diff.
2018-10-22 21:15:01 +02:00
Adrian Ulrich c6fedb9e17 do not index hidden files or folders. 2018-10-22 21:03:24 +02:00
Adrian Ulrich e3b878e69b fix loading of unindexed files via dispatch.
This is so brittle but the best thing we have - thanks to this patch, it even starts to work (again).
2018-10-22 20:34:32 +02:00
Toby Hsieh 17eea6c868 Display durations in albums tab (#857) 2018-10-22 19:00:33 +02:00
Toby Hsieh 6ab4e137ac Set STYLE_NO_TITLE for TrackDetailsDialog (#855)
This gets rid of the blank title section in the dialog when shown on the
playlist activity and on older versions of Android.
2018-10-19 08:04:51 +02:00
Toby Hsieh 71acc1782d Add context menu for song/track details dialog (#849)
* Add context menu for song/track details dialog

This addresses #506

* Add GPL 3 boilerplate to files

* Refactor track and disc number string for song details
2018-10-17 08:24:53 +02:00
Adrian Ulrich 7339681907 use Long.valueOf 2018-10-14 20:13:54 +02:00
Adrian Ulrich dd24247fea remove reference to context in static class. 2018-10-14 20:09:59 +02:00
Adrian Ulrich d1af6dab36 use apply() to store preferences. 2018-10-14 19:54:52 +02:00
Adrian Ulrich ce9ccd9bd4 Unregister sharedpreferences listener on destroy.
If the playback service is stopped before the main activity gets killed, this would have caused the old class to still get updates.

Sending preference updates to such an orphaned PlaybackService would trigger crashes in some cases (especially when MediaLibrary detects suspicious unregisters).
2018-10-14 19:44:51 +02:00
Antic1tizen One e2598806ac No smooth scroll if user doesn't see it. Fixes vanilla-music/vanilla#844 (#847)
The change adds interactive check to see if smooth scroll is actually
needed. If user doesn't see the library screen there's no point in
doing smooth scroll.

Besides, for old Android versions (like 4.x)
View.getFirstVisiblePosition, View.getLastVisiblePosition calls are
working only if view is currently visible.
2018-10-13 12:13:57 +02:00
Adrian Ulrich 12824fd47b make enterSleepState() synchronized.
There are a few crashes in the play store where the framework complains that we are underlocked.
Maybe this races with onDestroy() in some rare cases.
2018-10-13 09:42:52 +02:00
Adrian Ulrich 8e607cb242 target 1.0.73 2018-09-29 10:50:06 +02:00
Antic1tizen One 45b6063515 Update plugin waking code, fix crash on Oreo devices (#840)
* Update plugin waking code, fix crash on Oreo devices

In Android Oreo we can't use services without bringing them to the
foreground, i.e. showing icon and following specified lifecycle.

After some consideration the new way was implemented for plugin system.
Plugins will no longer have bound service and instead will do everything
required from within their activities. All background logic that
previously resided in services will now be performed before the activity
has even shown its window. This greatly reduces complexity and cost
associated with bringing service model in accordance with Oreo
guidelines. The only downside to this approach is small flickering
or pause in emulators as activities still expect to show themselves
on start instead of disappearing again.

* Move value to class-level constant
2018-09-29 10:47:47 +02:00
Adrian Ulrich fca6f14ab2 target 1.0.72 2018-08-29 18:01:11 +02:00
Adrian Ulrich 4bd4fb700a Really fix file picker. 2018-08-26 16:47:22 +02:00
Dmitri Davydok 3f0c7bb7a3 Implement some of the features present in Google Play Music: (#804)
report the current song's position in the queue to the remote control;
report the current song's playback position to the remote control.
2018-08-21 21:04:06 +02:00
Adrian Ulrich 90325aaf36 target 1.0.71 2018-08-21 07:32:18 +02:00
Adrian Ulrich ad7a220423 update translations 2018-08-21 07:30:47 +02:00
Antic1tizen One 2fdac736b3 Scroll the queue only when the requested song is not on screen (#812)
Now if the option "scroll to the queue position" is enabled and
a user is selecting a song in queue it immediately disappears from under
the finger and jumps to the top of currently visible list.

This patch fixes this behaviour - only scroll if next (or previous) song
falls out of list view visible range. I.e. sudden scrolling will never
happen if user clicks an item in queue as it's currently visible.
2018-08-20 21:23:55 +02:00
Adrian Ulrich e07fcc768b Fix file picker
We swapped the 'recursive' flag, shamecube.
2018-08-20 21:21:36 +02:00
Adrian Ulrich 5f9d91e9e7 target 1.0.70 2018-08-11 10:18:21 +02:00
Adrian Ulrich 240e8d6de6 update translations 2018-08-11 10:15:33 +02:00
Adrian Ulrich d0fbb0eed0 Add minor PlaylistObserver bugfixes.
* use mHandler.quit() on lower API versions
* do not trust filesystem version of playlists if folder is not writable
* disable debug logger
2018-08-11 10:14:10 +02:00
Adrian Ulrich 480df8e99a use setSong() callback in scrolling 2018-08-06 19:49:38 +02:00
Adrian Ulrich ed77cc8196 update translations 2018-08-05 12:43:49 +02:00
minus a44d959716 Add option to scroll to new track on song change (#802)
Adds a new setting to scroll the queue to the new song after a song
change. The new song will be at the top of the view.
2018-08-05 11:01:46 +02:00
Adrian Ulrich 0a9297a16c disable playlist sync by default 2018-08-04 08:55:46 +02:00
Ub1Catcrush 317641bc30 A patch to add support for covers stored in the media files ID3Tag. (#796)
* A patch to add support for covers stored in the media files IDTag.

* implement some suggested changes

* implement review comments
2018-07-21 17:53:20 +02:00
Adrian Ulrich 4e3c440f80 Make playlist folder a config option 2018-07-15 21:01:41 +02:00
Adrian Ulrich a8f84d85b4 Add dependency support to ListPreferenceSummary.
Disable dependent views if value is "0".
2018-07-15 20:36:08 +02:00
Adrian Ulrich 068352505c Do not import M3U if no metadata exists 2018-07-15 19:45:07 +02:00