third-party-mirrors/EDDN
1
0
Fork 0
mirror of https://github.com/EDCD/EDDN.git synced 2025-06-17 07:41:01 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Gateway/errors: Tag FAIL if a zlib.error

Browse Source
This commit is contained in:
Athanasius 2022-01-09 15:43:12 +00:00
parent 8edae919e2
commit 4da60215f0
No known key found for this signature in database
GPG Key ID: AE3E527847057C7D
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
schemas/README-EDDN-schemas.md
View File

@ -312,27 +312,30 @@ make a valid request" responses you might experience the following:
#### EDDN Gateway responses #### EDDN Gateway responses
1. `400` - `Bad Request` - this can be for a variety of reasons, and should 1. `400` - `Bad Request` - this can be for a variety of reasons, and should
come with a response body with a `FAIL: ` prefix: come with a response body with a `FAIL: ` prefix:
1. `FAIL: JSON parsing: <detail>` - the 1. `FAIL: zlib.error: <detail>` - A failure to decompress a message that
claimed to be compressed.
2. `FAIL: JSON parsing: <detail>` - the
request couldn't be parsed as valid JSON. e.g. request couldn't be parsed as valid JSON. e.g.
``` ```
FAIL: JSON parsing: Expecting property name enclosed in double quotes: line 1 column 2 (char 1) FAIL: JSON parsing: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
``` ```
2. `FAIL: [<ValidationError: "<schema validation failure>"]` - the JSON 3. `FAIL: [<ValidationError: "<schema validation failure>"]` - the JSON
message failed to pass schema validation. e.g. message failed to pass schema validation. e.g.
``` ```
FAIL: [<ValidationError: "'StarPos' is a required property">] FAIL: [<ValidationError: "'StarPos' is a required property">]
``` ```
3. Other python exception message, e.g. if a message appeared to be 4. Other python exception message, e.g. if a message appeared to be
gzip compressed, but a failure was experienced when attempting to gzip compressed, but a failure was experienced when attempting to
decompress it. **NB: As of 2022-07-01 such messages won't have the decompress it. **NB: As of 2022-07-01 such messages won't have the
`FAIL: ` prefix.** See `FAIL: ` prefix.** See
[#161 - Gateway: Improve reporting of 'misc' errors ](https://github.com/EDCD/EDDN/issues/161) [#161 - Gateway: Improve reporting of 'misc' errors ](https://github.com/EDCD/EDDN/issues/161)
for any progress/resolution on this. for any progress/resolution on this.
2. `426` - `Upgrade Required` - You sent a message with an outdated 3. `426` - `Upgrade Required` - You sent a message with an outdated
`$schemaRef` value. This could be either an old, deprecated version of `$schemaRef` value. This could be either an old, deprecated version of
a schema, or an entirely deprecated schema. e.g. a schema, or an entirely deprecated schema. e.g.

2
src/eddn/Gateway.py
View File

@ -300,7 +300,7 @@ def upload():
response.status = 400 response.status = 400
logger.error("MalformedUploadError from %s: %s" % (get_remote_address(), exc.message)) logger.error("MalformedUploadError from %s: %s" % (get_remote_address(), exc.message))
return 'FAIL: ' + exc.message return 'FAIL: Malformed Upload: ' + exc.message
statsCollector.tally("inbound") statsCollector.tally("inbound")
return parse_and_error_handle(message_body) return parse_and_error_handle(message_body)