From 522189ec36f28e25fc387fd8fd905fca5b4e43a6 Mon Sep 17 00:00:00 2001 From: Tobias Speicher Date: Tue, 22 Mar 2022 10:02:41 +0100 Subject: [PATCH 1/3] refactor: replace deprecated String.prototype.substr() .substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher --- contrib/monitor/schemas.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/monitor/schemas.html b/contrib/monitor/schemas.html index 4940b3b..d9c2aa5 100644 --- a/contrib/monitor/schemas.html +++ b/contrib/monitor/schemas.html @@ -241,7 +241,7 @@ // Loop results $.each(schemasCount, function(schema, hits){ // IF TEST CONTINUE - if(schema.substr(schema.length - 4) == 'test') + if(schema.slice(-4) == 'test') return; var slug = makeSlug(schema); From c54f452bf7f75bbc45c8fca9ee4a7bacaed7d5a3 Mon Sep 17 00:00:00 2001 From: Athanasius Date: Mon, 31 Oct 2022 08:49:33 +0000 Subject: [PATCH 2/3] docs/Developers: Compression needs `Content-Encoding` header ... not `Content-Type`. --- docs/Developers.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/Developers.md b/docs/Developers.md index 824b271..f547dbc 100644 --- a/docs/Developers.md +++ b/docs/Developers.md @@ -128,8 +128,8 @@ compress this body then you MUST set a `Content-Type` header of `applicaton/json`. You *MAY* use gzip compression on the body of the message, but it is not -required. If you do compress the body then you **MUST* send a `Content-Type` -header of `gzip` instead of `application/json`. +required. If you do compress the body then you **MUST* send a +`Content-Encoding` header of `gzip`. **Due to issues when messages are compressed, form-encoded data is NO LONGER SUPPORTED as of 2022-06-16.** From fecaf76e920b384d36ec6aab2d1b7ef3953f7935 Mon Sep 17 00:00:00 2001 From: Athanasius Date: Wed, 23 Nov 2022 17:50:15 +0000 Subject: [PATCH 3/3] schemas/README: Point out the status of gameversion/build in main README --- schemas/README-EDDN-schemas.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/schemas/README-EDDN-schemas.md b/schemas/README-EDDN-schemas.md index 8423755..5568e2d 100644 --- a/schemas/README-EDDN-schemas.md +++ b/schemas/README-EDDN-schemas.md @@ -54,6 +54,16 @@ contents all Schemas specify a top-level JSON Object with the data: relevant README file within this documentation, e.g. [codexentry-README.md](./codexentry-README.md). +Whilst currently (2022-11-23) the `gameversion` and `gamebuild` fields in the +message `header` aren't yet mandatory in the sense of what's in the schema +definitions, all Senders are **strongly encouraged** to send them. + +Indeed, the per-schema documentation, for every schema now states: + +#### gameversion and gamebuild +You **MUST** always set these as per [the relevant section](../docs/Developers.md#gameversions-and-gamebuild) +of the Developers' documentation. + ### General EDDN message outline Each `message` object must have, at bare minimum: