Merge pull request #32 from chincheta0815/docker_updates

change docker commands to get more images updates

.github/workflows/build.yml

@@ -149,15 +149,26 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v4
 
-    - name: Build ARM ffmpeg on Debian
+    - name: Build ARM ffmpeg on Bullseye
       run: |
-        docker build -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_ffmpeg
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_ffmpeg
+        docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
+
+    - name: Upload artifacts 
+      uses: actions/upload-artifact@v4
+      with: 
+        name: bliss-analyser-debian-bullseye-arm-ffmpeg
+        path: releases/
+
+    - name: Build ARM ffmpeg on Bookworm
+      run: |
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bookworm_ffmpeg
         docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
 
     - name: Upload artifacts
       uses: actions/upload-artifact@v4
       with:
-        name: bliss-analyser-linux-arm-ffmpeg
+        name: bliss-analyser-debian-bookworm-arm-ffmpeg
         path: releases/
 
 
@@ -170,7 +181,7 @@ jobs:
 
     - name: Build ARM static-libav on Debian
       run: |
-        docker build -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_static
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_static
         docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
 
     - name: Upload artifacts
@@ -189,7 +200,7 @@ jobs:
 
     - name: Build ARM libav on Bullseye
       run: |
-        docker build -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_libav
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_libav
         docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
 
     - name: Upload artifacts
@@ -200,7 +211,7 @@ jobs:
 
     - name: Build ARM libav on Bookworm
       run : |
-        docker build -t bliss-analyser-cross - < docker/Dockerfile_Bookworm_libav
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bookworm_libav
         docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
 
     - name: Upload artifacts
@@ -219,7 +230,7 @@ jobs:
 
     - name: Build ARM symphonia on Debian
       run: |
-        docker build -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_symphonia
+        docker build --pull --no-cache -t bliss-analyser-cross - < docker/Dockerfile_Bullseye_symphonia
         docker run --rm -v $PWD/target:/build -v $PWD:/src bliss-analyser-cross
 
     - name: Upload artifacts
@@ -482,4 +493,4 @@ jobs:
       uses: actions/upload-artifact@v4
       with:
         name: bliss-analyser-windows-symphonia
-        path: releases/
+        path: releases/

Cargo.lock

@@ -180,7 +180,7 @@ dependencies = [
 
 [[package]]
 name = "bliss-analyser"
-version = "0.4.0"
+version = "0.4.1"
 dependencies = [
  "anyhow",
  "argparse",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "bliss-analyser"
-version = "0.4.0"
+version = "0.4.1"
 authors = ["Craig Drummond <craig.p.drummond@gmail.com>"]
 edition = "2021"
 license = "GPL-3.0-only"

ChangeLog

@@ -1,3 +1,7 @@
+0.4.1
+-----
+1. Don't crash if file has no tags.
+
 0.4.0
 -----
 1. Add action to export results from DB to files.

src/tags.rs

@@ -151,7 +151,13 @@ pub fn read(track: &String, read_analysis: bool) -> db::Metadata {
     if let Ok(file) = lofty::read_from_path(Path::new(track)) {
         let tag = match file.primary_tag() {
             Some(primary_tag) => primary_tag,
-            None => file.first_tag().expect("Error: No tags found!"),
+            None => {
+                if let Some(first_tag) = file.first_tag() {
+                    first_tag
+                } else {
+                    return meta;
+                }
+            }
         };
 
         meta.title = tag.title().unwrap_or_default().to_string();