refactor

Signed-off-by: Deluan <deluan@navidrome.org>

core/extdata/export_test.go

@@ -1,4 +0,0 @@
-package extdata
-
-// Expose internal types for testing
-type MockAgents = mockAgents

core/extdata/extdata_helper_test.go

@@ -1,4 +1,4 @@
-package extdata
+package extdata_test
 
 import (
 	"context"

core/extdata/provider_albumimage_test.go

@@ -1,4 +1,4 @@
-package extdata
+package extdata_test
 
 import (
 	"context"
@@ -7,6 +7,7 @@ import (
 
 	"github.com/navidrome/navidrome/conf"
 	"github.com/navidrome/navidrome/core/agents"
+	. "github.com/navidrome/navidrome/core/extdata"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/tests"
 	. "github.com/onsi/ginkgo/v2"

core/extdata/provider_artistimage_test.go

@@ -1,4 +1,4 @@
-package extdata
+package extdata_test
 
 import (
 	"context"
@@ -7,6 +7,7 @@ import (
 
 	"github.com/navidrome/navidrome/conf"
 	"github.com/navidrome/navidrome/core/agents"
+	. "github.com/navidrome/navidrome/core/extdata"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/tests"
 	. "github.com/onsi/ginkgo/v2"

core/extdata/provider_similarsongs_test.go

@@ -1,4 +1,4 @@
-package extdata
+package extdata_test
 
 import (
 	"context"
@@ -6,6 +6,7 @@ import (
 
 	"github.com/navidrome/navidrome/conf"
 	"github.com/navidrome/navidrome/core/agents"
+	. "github.com/navidrome/navidrome/core/extdata"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/tests"
 	. "github.com/onsi/ginkgo/v2"

core/extdata/provider_topsongs_test.go

@@ -1,4 +1,4 @@
-package extdata
+package extdata_test
 
 import (
 	"context"
@@ -9,6 +9,7 @@ import (
 	_ "github.com/navidrome/navidrome/core/agents/lastfm"
 	_ "github.com/navidrome/navidrome/core/agents/listenbrainz"
 	_ "github.com/navidrome/navidrome/core/agents/spotify"
+	. "github.com/navidrome/navidrome/core/extdata"
 	"github.com/navidrome/navidrome/model"
 	"github.com/navidrome/navidrome/tests"
 	. "github.com/onsi/ginkgo/v2"
@@ -21,7 +22,7 @@ var _ = Describe("Provider - TopSongs", func() {
 		p                    Provider
 		artistRepo           *mockArtistRepo    // From provider_helper_test.go
 		mediaFileRepo        *mockMediaFileRepo // From provider_helper_test.go
-		ag                   *MockAgents        // Consolidated mock from export_test.go
+		ag                   *mockAgents        // Consolidated mock from export_test.go
 		ctx                  context.Context
 		originalAgentsConfig string
 	)
@@ -39,7 +40,7 @@ var _ = Describe("Provider - TopSongs", func() {
 			MockedMediaFile: mediaFileRepo,
 		}
 
-		ag = new(MockAgents)
+		ag = new(mockAgents)
 
 		p = NewProvider(ds, ag)
 	})

core/extdata/provider_updatealbuminfo_test.go

@@ -26,14 +26,14 @@ var _ = Describe("Provider UpdateAlbumInfo", func() {
 		ctx           context.Context
 		p             extdata.Provider
 		ds            *tests.MockDataStore
-		ag            *extdata.MockAgents
+		ag            *mockAgents
 		mockAlbumRepo *tests.MockAlbumRepo
 	)
 
 	BeforeEach(func() {
 		ctx = context.Background()
 		ds = new(tests.MockDataStore)
-		ag = new(extdata.MockAgents)
+		ag = new(mockAgents)
 		p = extdata.NewProvider(ds, ag)
 		mockAlbumRepo = ds.Album(ctx).(*tests.MockAlbumRepo)
 		conf.Server.DevAlbumInfoTimeToLive = 1 * time.Hour

core/extdata/provider_updateartistinfo_test.go

@@ -26,14 +26,14 @@ var _ = Describe("Provider UpdateArtistInfo", func() {
 		ctx            context.Context
 		p              extdata.Provider
 		ds             *tests.MockDataStore
-		ag             *extdata.MockAgents
+		ag             *mockAgents
 		mockArtistRepo *tests.MockArtistRepo
 	)
 
 	BeforeEach(func() {
 		ctx = context.Background()
 		ds = new(tests.MockDataStore)
-		ag = new(extdata.MockAgents)
+		ag = new(mockAgents)
 		p = extdata.NewProvider(ds, ag)
 		mockArtistRepo = ds.Artist(ctx).(*tests.MockArtistRepo)
 		conf.Server.DevArtistInfoTimeToLive = 1 * time.Hour