third-party-mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-17 04:22:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable User.lastAccessAt field for now.

Browse Source 
Updating it on every request was cause DB retentions/lock errors
This commit is contained in:
Deluan 2020-01-28 16:20:59 -05:00
parent d4edff3aaa
commit 3007ca68d5
3 changed files with 10 additions and 11 deletions

14
engine/users.go

@ -7,7 +7,6 @@ import (
"fmt"
"strings"
"github.com/deluan/navidrome/log"
"github.com/deluan/navidrome/model"
)
@ -49,11 +48,12 @@ func (u *users) Authenticate(ctx context.Context, username, pass, token, salt st
if !valid {
return nil, model.ErrInvalidAuth
}
go func() {
err := u.ds.User(ctx).UpdateLastAccessAt(user.ID)
if err != nil {
log.Error(ctx, "Could not update user's lastAccessAt", "user", user.UserName)
}
}()
// TODO: Find a way to update LastAccessAt without causing too much retention in the DB
//go func() {
// err := u.ds.User(ctx).UpdateLastAccessAt(user.ID)
// if err != nil {
// log.Error(ctx, "Could not update user's lastAccessAt", "user", user.UserName)
// }
//}()
return user, nil
}

2
ui/src/user/UserEdit.js

@ -23,7 +23,7 @@ const UserEdit = (props) => (
<PasswordInput source="password" validate={[required()]} />
<BooleanInput source="isAdmin" initialValue={false} />
<DateField source="lastLoginAt" showTime />
<DateField source="lastAccessAt" showTime />
{/*<DateField source="lastAccessAt" showTime />*/}
<DateField source="updatedAt" showTime />
<DateField source="createdAt" showTime />
</SimpleForm>

5
ui/src/user/UserList.js

@ -33,8 +33,7 @@ const UserList = (props) => {
<SimpleList
primaryText={(record) => record.name}
secondaryText={(record) =>
record.lastAccessAt &&
new Date(record.lastAccessAt).toLocaleString()
record.lastLoginAt && new Date(record.lastLoginAt).toLocaleString()
}
tertiaryText={(record) => (record.isAdmin ? '[admin]️' : '')}
/>
@ -42,7 +41,7 @@ const UserList = (props) => {
<Datagrid rowClick="edit">
<TextField source="userName" />
<BooleanField source="isAdmin" />
<DateField source="lastAccessAt" locales="pt-BR" />
<DateField source="lastLoginAt" locales="pt-BR" />
<DateField source="updatedAt" locales="pt-BR" />
</Datagrid>
)}