third-party-mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-04-18 21:07:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Parse ParamBool case-insensitively (#1151)

Browse Source
This commit is contained in:
Steve Richter 2021-06-04 23:37:01 -04:00 committed by GitHub
parent bebfe296a5
commit 65ccd4c99d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
utils/request_helpers.go
View File

@ -84,7 +84,7 @@ func ParamInts(r *http.Request, param string) []int {
} }
func ParamBool(r *http.Request, param string, def bool) bool { func ParamBool(r *http.Request, param string, def bool) bool {
p := ParamString(r, param) p := strings.ToLower(ParamString(r, param))
if p == "" { if p == "" {
return def return def
} }

6
utils/request_helpers_test.go
View File

@ -147,7 +147,7 @@ var _ = Describe("Request Helpers", func() {
Describe("ParamBool", func() { Describe("ParamBool", func() {
Context("value is true", func() { Context("value is true", func() {
BeforeEach(func() { BeforeEach(func() {
r = httptest.NewRequest("GET", "/ping?b=true&c=on&d=1", nil) r = httptest.NewRequest("GET", "/ping?b=true&c=on&d=1&e=True", nil)
}) })
It("parses 'true'", func() { It("parses 'true'", func() {
@ -161,6 +161,10 @@ var _ = Describe("Request Helpers", func() {
It("parses '1'", func() { It("parses '1'", func() {
Expect(ParamBool(r, "d", false)).To(BeTrue()) Expect(ParamBool(r, "d", false)).To(BeTrue())
}) })
It("parses 'True'", func() {
Expect(ParamBool(r, "e", false)).To(BeTrue())
})
}) })
Context("value is false", func() { Context("value is false", func() {