third-party-mirrors/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-06-06 02:13:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(scanner): optimize missing flag update logic for artists

Browse Source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2025-05-24 11:28:39 -04:00
parent a9f93c97e1
commit 6bf6424864
2 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
persistence/artist_repository.go
View File

@ -244,24 +244,23 @@ func (r *artistRepository) purgeEmpty() error {
return nil return nil
} }
// markMissing sets the Missing flag based on album data. // markMissing marks artists as missing if all their albums are missing.
func (r *artistRepository) markMissing() (int64, error) { func (r *artistRepository) markMissing() error {
q := Expr(` q := Expr(`
update artist with artists_with_non_missing_albums as (
set missing = not exists ( select distinct aa.artist_id
select 1 from album_artists aa from album_artists aa
join album a on aa.album_id = a.id join album a on aa.album_id = a.id
where aa.artist_id = artist.id and a.missing = false where a.missing = false
) )
update artist
set missing = (artist.id not in (select artist_id from artists_with_non_missing_albums));
`) `)
c, err := r.executeSQL(q) _, err := r.executeSQL(q)
if err != nil { if err != nil {
return 0, fmt.Errorf("marking missing artists: %w", err) return fmt.Errorf("marking missing artists: %w", err)
} }
if c > 0 { return nil
log.Debug(r.ctx, "Marked missing artists", "totalUpdated", c)
}
return c, nil
} }
// RefreshPlayCounts updates the play count and last play date annotations for all artists, based // RefreshPlayCounts updates the play count and last play date annotations for all artists, based

2
persistence/persistence.go
View File

@ -170,7 +170,7 @@ func (s *SQLStore) GC(ctx context.Context) error {
err := chain.RunSequentially( err := chain.RunSequentially(
trace(ctx, "purge empty albums", func() error { return s.Album(ctx).(*albumRepository).purgeEmpty() }), trace(ctx, "purge empty albums", func() error { return s.Album(ctx).(*albumRepository).purgeEmpty() }),
trace(ctx, "purge empty artists", func() error { return s.Artist(ctx).(*artistRepository).purgeEmpty() }), trace(ctx, "purge empty artists", func() error { return s.Artist(ctx).(*artistRepository).purgeEmpty() }),
trace(ctx, "mark missing artists", func() error { _, err := s.Artist(ctx).(*artistRepository).markMissing(); return err }), trace(ctx, "mark missing artists", func() error { return s.Artist(ctx).(*artistRepository).markMissing() }),
trace(ctx, "purge empty folders", func() error { return s.Folder(ctx).(*folderRepository).purgeEmpty() }), trace(ctx, "purge empty folders", func() error { return s.Folder(ctx).(*folderRepository).purgeEmpty() }),
trace(ctx, "clean album annotations", func() error { return s.Album(ctx).(*albumRepository).cleanAnnotations() }), trace(ctx, "clean album annotations", func() error { return s.Album(ctx).(*albumRepository).cleanAnnotations() }),
trace(ctx, "clean artist annotations", func() error { return s.Artist(ctx).(*artistRepository).cleanAnnotations() }), trace(ctx, "clean artist annotations", func() error { return s.Artist(ctx).(*artistRepository).cleanAnnotations() }),