From 854023df0ae68b0b6a15065bcfb7b7eeea3898f5 Mon Sep 17 00:00:00 2001 From: Deluan Date: Thu, 17 Apr 2025 19:16:18 -0400 Subject: [PATCH] fix: remove remaining releaseDate references in SongDatagrid Cleaned up leftover `releaseDate` references in `SongDatagrid.jsx`: - Removed `releaseDate` parameter and usage from `handlePlaySubset` in `DiscSubtitleRow`. - Removed `releaseDate` prop passed to `AlbumContextMenu` in `DiscSubtitleRow`. - Removed `releaseDate` from the drag item data in `SongDatagridRow`. - Removed `releaseDate` parameter and the corresponding `else` block from the `playSubset` function in `SongDatagridBody`. This ensures the component consistently uses `discNumber` for grouping and playback actions initiated from the disc subtitle, fully resolving the inconsistencies related to issue #3720. --- ui/src/common/SongDatagrid.jsx | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/ui/src/common/SongDatagrid.jsx b/ui/src/common/SongDatagrid.jsx index 29e8e2b2d..3586cf225 100644 --- a/ui/src/common/SongDatagrid.jsx +++ b/ui/src/common/SongDatagrid.jsx @@ -63,8 +63,8 @@ const DiscSubtitleRow = forwardRef( ({ record, onClick, colSpan, contextAlwaysVisible }, ref) => { const isDesktop = useMediaQuery((theme) => theme.breakpoints.up('md')) const classes = useStyles({ isDesktop }) - const handlePlaySubset = (releaseDate, discNumber) => () => { - onClick(releaseDate, discNumber) + const handlePlaySubset = (discNumber) => () => { + onClick(discNumber) } let subtitle = [] @@ -79,7 +79,7 @@ const DiscSubtitleRow = forwardRef( @@ -92,7 +92,6 @@ const DiscSubtitleRow = forwardRef( { + (discNumber) => { let idsToPlay = [] if (discNumber !== undefined) { - idsToPlay = ids.filter( - (id) => - data[id].releaseDate === releaseDate && - data[id].discNumber === discNumber, - ) - } else { - idsToPlay = ids.filter((id) => data[id].releaseDate === releaseDate) + idsToPlay = ids.filter((id) => data[id].discNumber === discNumber) } dispatch( playTracks(