From c4d156944148020588c138857ade63f6a0a84ba2 Mon Sep 17 00:00:00 2001 From: Robert Sammelson Date: Sat, 3 Dec 2022 20:31:02 -0500 Subject: [PATCH] Fix bug in duration format logic (#2026) --- ui/src/utils/formatters.js | 2 +- ui/src/utils/formatters.test.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/src/utils/formatters.js b/ui/src/utils/formatters.js index a4de54bbd..b6764cd9a 100644 --- a/ui/src/utils/formatters.js +++ b/ui/src/utils/formatters.js @@ -19,7 +19,7 @@ export const formatDuration = (d) => { const f = [hours, minutes, seconds] .map((v) => v.toString()) .map((v) => (v.length !== 2 ? '0' + v : v)) - .filter((v, i) => v !== '00' || i > 0) + .filter((v, i) => v !== '00' || i > 0 || days > 0) .join(':') return `${days > 0 ? days + ':' : ''}${f}` diff --git a/ui/src/utils/formatters.test.js b/ui/src/utils/formatters.test.js index 0b853e728..056ade12e 100644 --- a/ui/src/utils/formatters.test.js +++ b/ui/src/utils/formatters.test.js @@ -27,5 +27,7 @@ describe('formatDuration', () => { expect(formatDuration(3 * day + 3 * hour + 7 * minute)).toEqual( '3:03:07:00' ) + expect(formatDuration(day)).toEqual('1:00:00:00') + expect(formatDuration(day + minute + 0.6)).toEqual('1:00:01:01') }) })