From d9c991e325c70dcc92a8060d5709fc230b5368e5 Mon Sep 17 00:00:00 2001
From: Alex Palaistras <alex@deuill.org>
Date: Sun, 14 Jun 2020 11:11:23 +0100
Subject: [PATCH] Return error when no matching cover is found

When checking stored references to cover images (whether embedded or
external), it's possible that configured patterns do no match, and a
valid error should be returned in those cases.
---
 engine/cover.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/engine/cover.go b/engine/cover.go
index 4be93e106..7aa2363a0 100644
--- a/engine/cover.go
+++ b/engine/cover.go
@@ -135,6 +135,7 @@ func (c *cover) getCover(ctx context.Context, path string, size int) (reader io.
 		}
 	}()
 	var data []byte
+	err = errors.New("no matching cover found")
 	for _, p := range strings.Split(conf.Server.CoverArtPriority, ",") {
 		pat := strings.ToLower(strings.TrimSpace(p))
 		if pat == "embedded" {
@@ -147,7 +148,9 @@ func (c *cover) getCover(ctx context.Context, path string, size int) (reader io.
 		}
 	}
 
-	if err == nil && size > 0 {
+	if err != nil {
+		return
+	} else if size > 0 {
 		data, err = resizeImage(bytes.NewReader(data), size)
 	}