Deluan
ccce1c0f6d
fix: pre-cache square images, or else they are not useful for the Album Grid
...
Signed-off-by: Deluan <deluan@navidrome.org>
2024-11-19 18:41:50 -05:00
Deluan
81edef925c
refactor: when resizing, don't buffer the original image "just in case"
...
Signed-off-by: Deluan <deluan@navidrome.org>
2024-11-19 18:41:50 -05:00
Deluan
2d4f483812
refactor: remove unnecessary intermediate buffer for ffmpeg image extraction
...
Signed-off-by: Deluan <deluan@navidrome.org>
2024-11-19 18:41:50 -05:00
Deluan Quintão
3fda7445b0
fix(server): try to find proper embedded front cover - only for vorbis comments for now ( #3348 )
...
* fix(artwork): get the first image from vorbis comments, not the last. fixes #3254
This uses a fork for now.
* fix(artwork): prioritize getting embedded types that are listed as "front" covers
* fix: cleanup
2024-10-27 21:59:22 -04:00
Deluan Quintão
c4bd0e67fa
Upgrade Go to 1.23 ( #3190 )
...
* Upgrade to Golang 1.23rc1
* Fix imports
* Go 1.23 final version
* Fix lint compatibility with ci-goreleaser
2024-08-19 17:47:54 -04:00
Deluan
e1ba152a38
Reduce noise in logs when pre-caching artwork
2024-08-07 13:08:54 -04:00
Deluan
e434ca9372
Change resized image cache key
2024-06-08 13:37:30 -04:00
Deluan
abe5690018
Refactor string utilities into its own package str
2024-06-05 22:09:27 -04:00
Caio Cotts
0488fb92cb
Fix image stuttering ( #3035 )
...
* Fix image stuttering.
* Fix docker publishing for PRs
* Write tests for new square parameter.
* Simplify code for createImage.
---------
Co-authored-by: Deluan Quintão <deluan@navidrome.org>
2024-05-24 20:19:26 -04:00
Deluan
7f52ff72dc
Simplify image format detection code
2024-05-16 13:49:40 -04:00
Deluan
8ed07333ed
Improve resizeImage code readability
2024-05-16 13:49:40 -04:00
oftenoccur
bcb71b85c0
Fix some typos in comments ( #2949 )
...
Signed-off-by: oftenoccur <ezc5@sina.com>
2024-04-11 14:58:14 -04:00
Deluan
166eb37787
Use Go builtin min/max func
2024-02-16 21:53:16 -05:00
Deluan
6a8d2dc87d
Only use valid images for artist.* artwork
2023-04-03 18:07:15 -04:00
Joakim Repomaa
2ccc5bc941
Implement artist art priority ( #2266 )
...
* implement artist art priority
* add tests
2023-03-30 18:28:05 -04:00
Deluan
806713719f
Add lastUpdated to coverArt ids. Helps with invalidating art cache client-side.
2023-02-08 20:03:31 -05:00
Deluan
ee8f6447eb
Add option to disable Cache Warmer. Related to #2142
2023-02-06 10:41:33 -05:00
Deluan
9b81aa4403
Fix artwork resolution when paths contains :. Fix #2137
2023-02-02 12:18:55 -05:00
Deluan
f4b50c493c
When retrieving images from external sources, avoid calling it again if data is already cached locally.
...
Relates to https://github.com/navidrome/navidrome/issues/2130#issuecomment-1412742918
2023-02-02 10:38:17 -05:00
Deluan
4a7e86e989
Fix file descriptor leaking.
2023-02-02 10:36:49 -05:00
Deluan
f00e6117ff
Invalidate artist cache (by changing cache key format)
2023-02-01 10:34:55 -05:00
Deluan
d8e794317f
Return 404 when artwork is not available in /share/img endpoint
2023-02-01 10:34:02 -05:00
Deluan
7fc964aec5
Don't wake CacheWarmer every 10 seconds, let it sleep :)
2023-01-18 19:31:15 -05:00
Deluan
580e9ae4bd
Fix timer going awry
2023-01-17 22:04:09 -05:00
Deluan
17eab6a88d
Fix resized image cache key
2023-01-17 20:58:38 -05:00
Deluan
bedd2b2074
Implement better artwork cache keys
2023-01-17 20:37:10 -05:00
Kendall Garner
93adda66d9
Get album info (when available) from Last.fm, add getAlbumInfo endpoint ( #2061 )
...
* lastfm album.getInfo, getAlbuminfo(2) endpoints
* ... for description and reduce not found log level
* address first comments
* return all images
* Update migration timestamp
* Handle a few edge cases
* Add CoverArtPriority option to retrieve albumart from external sources
* Make agents methods more descriptive
* Use Last.fm name consistently
Co-authored-by: Deluan <deluan@navidrome.org>
2023-01-17 20:22:54 -05:00
Deluan
5564f00838
Some refactor, log message changes
2023-01-17 17:26:48 -05:00
Deluan
e40da183bb
Move artwork id encoding to public package
2023-01-16 15:24:25 -05:00
Deluan
e3496c7eea
Fix artist folder detection. Now works when the artist has only one album.
2023-01-14 14:36:27 -05:00
Deluan
16c869ec86
Optimize playlist cover generation
2023-01-13 22:18:34 -05:00
Deluan
ab7668f562
Use a custom artist image cache key.
...
Invalidate when `Agents` config changes. This should solve https://github.com/navidrome/navidrome/issues/1601#issuecomment-1241702797
2023-01-13 22:18:34 -05:00
Deluan
94c6d47181
More descriptive error when artist.jpg not found
2023-01-13 22:18:34 -05:00
Deluan
3f2d24695e
PreCache artist images
2023-01-13 22:18:34 -05:00
Deluan
c90468b895
Find artist.* image in Artist folder
2023-01-13 22:18:34 -05:00
Deluan
69e0a266f4
Remove size from public image ID JWT
2023-01-13 22:18:34 -05:00
Deluan
77a99a735b
Always access artist images through Navidrome (proxy calls to external URLs)
2023-01-13 22:18:34 -05:00
Deluan
918fee3ea3
Artwork reader for Artist
2023-01-13 22:18:34 -05:00
Deluan
bf461473ef
Add local agent, only for images
2023-01-13 22:18:34 -05:00
Deluan
df0f140f9f
Don't refresh smart playlists when generating covers
2023-01-01 20:28:03 -05:00
Deluan
cc14485194
When trying to PreCache, wait for ImageCache to be available
2022-12-28 23:26:39 -05:00
Deluan
14032a524b
Reduce retention in CacheWarmer
2022-12-28 15:31:56 -05:00
Deluan
61e5523457
Handle "naked" CoverArtIDs (IDs of album, mediafiles and playlists)
2022-12-28 15:31:56 -05:00
Deluan
bc09de6640
Better error handling
2022-12-28 15:31:56 -05:00
Deluan
949331ed24
GetCoverArt generates a tiled (2x2) image for playlists
2022-12-28 15:31:56 -05:00
Deluan
501386b11f
Parse correctly playlist CoverArt ids
2022-12-28 15:31:56 -05:00
Deluan
8f3387a894
Fix tests and clean up code a bit
2022-12-28 15:31:56 -05:00
Deluan
332900774d
Rename DevFastAccessCoverArt to EnableMediaFileCoverArt
2022-12-28 15:31:56 -05:00
Deluan
722a00cacf
Fix artwork caching
2022-12-28 15:31:56 -05:00
Deluan
92ddae4a65
Created dedicated artwork readers
2022-12-28 15:31:56 -05:00
