mirror of
https://github.com/navidrome/navidrome.git
synced 2025-07-13 23:21:21 +03:00
d041cb3249
Updated the error handling logic in the plugin lifecycle manager to accurately record the success of the OnInit method. The change ensures that the metrics reflect whether the initialization was successful, improving the reliability of plugin metrics tracking. Additionally, removed the unused errorMapper interface from base_capability.go to clean up the codebase. Signed-off-by: Deluan <deluan@navidrome.org>
96 lines
3.1 KiB
Go
96 lines
3.1 KiB
Go
package plugins
|
|
|
|
import (
|
|
"context"
|
|
"maps"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/consts"
|
|
"github.com/navidrome/navidrome/core/metrics"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/plugins/api"
|
|
)
|
|
|
|
// pluginLifecycleManager tracks which plugins have been initialized and manages their lifecycle
|
|
type pluginLifecycleManager struct {
|
|
plugins sync.Map // string -> bool
|
|
config map[string]map[string]string
|
|
metrics metrics.Metrics
|
|
}
|
|
|
|
// newPluginLifecycleManager creates a new plugin lifecycle manager
|
|
func newPluginLifecycleManager(metrics metrics.Metrics) *pluginLifecycleManager {
|
|
config := maps.Clone(conf.Server.PluginConfig)
|
|
return &pluginLifecycleManager{
|
|
config: config,
|
|
metrics: metrics,
|
|
}
|
|
}
|
|
|
|
// isInitialized checks if a plugin has been initialized
|
|
func (m *pluginLifecycleManager) isInitialized(plugin *plugin) bool {
|
|
key := plugin.ID + consts.Zwsp + plugin.Manifest.Version
|
|
value, exists := m.plugins.Load(key)
|
|
return exists && value.(bool)
|
|
}
|
|
|
|
// markInitialized marks a plugin as initialized
|
|
func (m *pluginLifecycleManager) markInitialized(plugin *plugin) {
|
|
key := plugin.ID + consts.Zwsp + plugin.Manifest.Version
|
|
m.plugins.Store(key, true)
|
|
}
|
|
|
|
// clearInitialized removes the initialization state of a plugin
|
|
func (m *pluginLifecycleManager) clearInitialized(plugin *plugin) {
|
|
key := plugin.ID + consts.Zwsp + plugin.Manifest.Version
|
|
m.plugins.Delete(key)
|
|
}
|
|
|
|
// callOnInit calls the OnInit method on a plugin that implements LifecycleManagement
|
|
func (m *pluginLifecycleManager) callOnInit(plugin *plugin) error {
|
|
ctx := context.Background()
|
|
log.Debug("Initializing plugin", "name", plugin.ID)
|
|
start := time.Now()
|
|
|
|
// Create LifecycleManagement plugin instance
|
|
loader, err := api.NewLifecycleManagementPlugin(ctx, api.WazeroRuntime(plugin.Runtime), api.WazeroModuleConfig(plugin.ModConfig))
|
|
if loader == nil || err != nil {
|
|
log.Error("Error creating LifecycleManagement plugin", "plugin", plugin.ID, err)
|
|
return err
|
|
}
|
|
|
|
initPlugin, err := loader.Load(ctx, plugin.WasmPath)
|
|
if err != nil {
|
|
log.Error("Error loading LifecycleManagement plugin", "plugin", plugin.ID, "path", plugin.WasmPath, err)
|
|
return err
|
|
}
|
|
defer initPlugin.Close(ctx)
|
|
|
|
// Prepare the request with plugin-specific configuration
|
|
req := &api.InitRequest{}
|
|
|
|
// Add plugin configuration if available
|
|
if m.config != nil {
|
|
if pluginConfig, ok := m.config[plugin.ID]; ok && len(pluginConfig) > 0 {
|
|
req.Config = maps.Clone(pluginConfig)
|
|
log.Debug("Passing configuration to plugin", "plugin", plugin.ID, "configKeys", len(pluginConfig))
|
|
}
|
|
}
|
|
|
|
// Call OnInit
|
|
callStart := time.Now()
|
|
_, err = checkErr(initPlugin.OnInit(ctx, req))
|
|
m.metrics.RecordPluginRequest(ctx, plugin.ID, "OnInit", err == nil, time.Since(callStart).Milliseconds())
|
|
if err != nil {
|
|
log.Error("Error initializing plugin", "plugin", plugin.ID, "elapsed", time.Since(start), err)
|
|
return err
|
|
}
|
|
|
|
// Mark the plugin as initialized
|
|
m.markInitialized(plugin)
|
|
log.Debug("Plugin initialized successfully", "plugin", plugin.ID, "elapsed", time.Since(start))
|
|
return nil
|
|
}
|