mirror of
https://github.com/navidrome/navidrome.git
synced 2025-05-03 11:51:33 +03:00
* persistence/genre: change Put() to upsert Absolutely disgusting hack to work around [1]. Try to insert the genre, but if it conflicts, ignore it and update the genre with the existing ID. [1]: https://github.com/navidrome/navidrome/issues/1918. * scanner: remove cached genre repository Not needed anytmore. And remember: "Many Small Queries Are Efficient In SQLite" [1]. [1]: https://www.sqlite.org/np1queryprob.html * Revert "scanner: remove cached genre repository" This reverts commit c5d900aa43e1c86b69f923b408e11ab8df8d815c. * Use squirrel to build SQL, to reduce risk of SQL injection Co-authored-by: Deluan <deluan@navidrome.org>
104 lines
2.9 KiB
Go
104 lines
2.9 KiB
Go
package persistence
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/uuid"
|
|
|
|
. "github.com/Masterminds/squirrel"
|
|
"github.com/beego/beego/v2/client/orm"
|
|
"github.com/deluan/rest"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
)
|
|
|
|
type genreRepository struct {
|
|
sqlRepository
|
|
sqlRestful
|
|
}
|
|
|
|
func NewGenreRepository(ctx context.Context, o orm.QueryExecutor) model.GenreRepository {
|
|
r := &genreRepository{}
|
|
r.ctx = ctx
|
|
r.ormer = o
|
|
r.tableName = "genre"
|
|
r.filterMappings = map[string]filterFunc{
|
|
"name": containsFilter,
|
|
}
|
|
return r
|
|
}
|
|
|
|
func (r *genreRepository) GetAll(opt ...model.QueryOptions) (model.Genres, error) {
|
|
sq := r.newSelect(opt...).Columns("genre.id", "genre.name", "a.album_count", "m.song_count").
|
|
LeftJoin("(select ag.genre_id, count(ag.album_id) as album_count from album_genres ag group by ag.genre_id) a on a.genre_id = genre.id").
|
|
LeftJoin("(select mg.genre_id, count(mg.media_file_id) as song_count from media_file_genres mg group by mg.genre_id) m on m.genre_id = genre.id")
|
|
res := model.Genres{}
|
|
err := r.queryAll(sq, &res)
|
|
return res, err
|
|
}
|
|
|
|
// Put is an Upsert operation, based on the name of the genre: If the name already exists, returns its ID, or else
|
|
// insert the new genre in the DB and returns its new created ID.
|
|
func (r *genreRepository) Put(m *model.Genre) error {
|
|
if m.ID == "" {
|
|
m.ID = uuid.NewString()
|
|
}
|
|
sql := Insert("genre").Columns("id", "name").Values(m.ID, m.Name).
|
|
Suffix("on conflict (name) do update set name=excluded.name returning id")
|
|
resp := model.Genre{}
|
|
err := r.queryOne(sql, &resp)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
m.ID = resp.ID
|
|
return nil
|
|
}
|
|
|
|
func (r *genreRepository) Count(options ...rest.QueryOptions) (int64, error) {
|
|
return r.count(Select(), r.parseRestOptions(options...))
|
|
}
|
|
|
|
func (r *genreRepository) Read(id string) (interface{}, error) {
|
|
sel := r.newSelect().Columns("*").Where(Eq{"id": id})
|
|
var res model.Genre
|
|
err := r.queryOne(sel, &res)
|
|
return &res, err
|
|
}
|
|
|
|
func (r *genreRepository) ReadAll(options ...rest.QueryOptions) (interface{}, error) {
|
|
sel := r.newSelect(r.parseRestOptions(options...)).Columns("*")
|
|
res := model.Genres{}
|
|
err := r.queryAll(sel, &res)
|
|
return res, err
|
|
}
|
|
|
|
func (r *genreRepository) EntityName() string {
|
|
return r.tableName
|
|
}
|
|
|
|
func (r *genreRepository) NewInstance() interface{} {
|
|
return &model.Genre{}
|
|
}
|
|
|
|
func (r *genreRepository) purgeEmpty() error {
|
|
del := Delete(r.tableName).Where(`id in (
|
|
select genre.id from genre
|
|
left join album_genres ag on genre.id = ag.genre_id
|
|
left join artist_genres a on genre.id = a.genre_id
|
|
left join media_file_genres mfg on genre.id = mfg.genre_id
|
|
where ag.genre_id is null
|
|
and a.genre_id is null
|
|
and mfg.genre_id is null
|
|
)`)
|
|
c, err := r.executeSQL(del)
|
|
if err == nil {
|
|
if c > 0 {
|
|
log.Debug(r.ctx, "Purged unused genres", "totalDeleted", c)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
var _ model.GenreRepository = (*genreRepository)(nil)
|
|
var _ model.ResourceRepository = (*genreRepository)(nil)
|