From aff7970628c7297cec99064a74b03d7b71536787 Mon Sep 17 00:00:00 2001 From: Blake Mizerany Date: Mon, 1 Apr 2024 23:41:42 -0700 Subject: [PATCH] build: remove superfluous parseCompleteRef --- build/build.go | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/build/build.go b/build/build.go index d26718a7..913d1d12 100644 --- a/build/build.go +++ b/build/build.go @@ -113,21 +113,13 @@ func (s *Server) LayerFile(digest string) (string, error) { } func (s *Server) ManifestData(ref string) ([]byte, error) { - br, err := parseCompleteRef(ref) - if err != nil { - return nil, err - } - data, _, err := s.resolve(br) + data, _, err := s.resolve(blob.ParseRef(ref)) return data, err } // WeightFile returns the absolute path to the weights file for the given model ref. func (s *Server) WeightsFile(ref string) (string, error) { - br, err := parseCompleteRef(ref) - if err != nil { - return "", err - } - m, err := s.getManifest(br) + m, err := s.getManifest(blob.ParseRef(ref)) if err != nil { return "", err } @@ -167,11 +159,7 @@ func (s *Server) resolve(ref blob.Ref) (data []byte, path string, err error) { } func (s *Server) SetManifestData(ref string, data []byte) error { - br, err := parseCompleteRef(ref) - if err != nil { - return err - } - return s.setManifestData(br, data) + return s.setManifestData(blob.ParseRef(ref), data) } // Set sets the data for the given ref. @@ -220,11 +208,3 @@ func (s *Server) getManifest(ref blob.Ref) (manifestJSON, error) { } return m, nil } - -func parseCompleteRef(ref string) (blob.Ref, error) { - br := blob.ParseRef(ref) - if !br.Complete() { - return blob.Ref{}, fmt.Errorf("%w: %q", ErrIncompleteRef, ref) - } - return br, nil -}