removed static known_source arrays, UDP connections are now managed dynamically

This commit is contained in:
yrutschle 2021-07-07 19:58:08 +02:00
parent 8af87ebbad
commit e7df8eeaa1
4 changed files with 51 additions and 85 deletions

View File

@ -95,15 +95,13 @@ struct queue {
int deferred_data_size; int deferred_data_size;
}; };
struct known_udp_source;
struct connection { struct connection {
int type; /* SOCK_DGRAM | SOCK_STREAM */ int type; /* SOCK_DGRAM | SOCK_STREAM */
struct sslhcfg_protocols_item* proto; /* Where to connect to */
/* SOCK_STREAM */ /* SOCK_STREAM */
enum connection_state state; enum connection_state state;
time_t probe_timeout; time_t probe_timeout;
struct sslhcfg_protocols_item* proto;
/* q[0]: queue for external connection (client); /* q[0]: queue for external connection (client);
* q[1]: queue for internal connection (httpd or sshd); * q[1]: queue for internal connection (httpd or sshd);
@ -111,7 +109,16 @@ struct connection {
struct queue q[2]; struct queue q[2];
/* SOCK_DGRAM */ /* SOCK_DGRAM */
struct known_udp_source* udp_source; struct sockaddr client_addr; /* Contains the remote client address */
socklen_t addrlen;
int local_endpoint; /* Contains the local address */
time_t last_active;
/* We need one local socket for each target server, so we know where to
* forward server responses */
int target_sock;
}; };

View File

@ -385,7 +385,7 @@ static void cnx_read_process(struct select_info* fd_info, int fd)
break; break;
case SOCK_DGRAM: case SOCK_DGRAM:
udp_s2c_forward(cnx->udp_source); udp_s2c_forward(cnx);
break; break;
default: default:
@ -442,7 +442,7 @@ void cnx_accept_process(struct select_info* fd_info, struct listen_endpoint* lis
break; break;
case SOCK_DGRAM: case SOCK_DGRAM:
new_fd = udp_c2s_forward(fd, fd_info->collection); new_fd = udp_c2s_forward(fd, fd_info->collection, fd_info->max_fd);
fprintf(stderr, "new_fd %d\n", new_fd); fprintf(stderr, "new_fd %d\n", new_fd);
if (new_fd == -1) if (new_fd == -1)
return; return;

View File

@ -26,23 +26,6 @@
#include "udp-listener.h" #include "udp-listener.h"
/* UDP support types and stuff */
struct known_udp_source {
int allocated;
struct sockaddr client_addr; /* Contains the remote client address */
socklen_t addrlen;
int local_endpoint; /* Contains the local address */
time_t last_active;
struct sslhcfg_protocols_item* proto; /* Where to connect it to */
/* We need one local socket for each target server, so we know where to
* forward server responses */
int target_sock;
};
/* Find if the specified source has been seen before. -1 if not found /* Find if the specified source has been seen before. -1 if not found
* *
* TODO This is linear search and needs to be changed to something better for * TODO This is linear search and needs to be changed to something better for
@ -50,13 +33,14 @@ struct known_udp_source {
* Also, this assumes src_addr from recvfrom() are repeatable for a specific * Also, this assumes src_addr from recvfrom() are repeatable for a specific
* source... * source...
* */ * */
static int known_source(struct known_udp_source* ks, int ks_len, struct sockaddr* addr, socklen_t addrlen) static int known_source(cnx_collection* collection, int max_fd, struct sockaddr* addr, socklen_t addrlen)
{ {
int i; int i;
for (i = 0; i < ks_len; i++) { for (i = 0; i < max_fd; i++) {
if (ks[i].allocated) { struct connection* cnx = collection_get_cnx_from_fd(collection, i);
if (!memcmp(&ks[i].client_addr, addr, addrlen)) { if (cnx && (cnx->type == SOCK_DGRAM) && cnx->target_sock) {
if (!memcmp(&cnx->client_addr, addr, addrlen)) {
return i; return i;
} }
} }
@ -64,30 +48,18 @@ static int known_source(struct known_udp_source* ks, int ks_len, struct sockaddr
return -1; return -1;
} }
static int get_empty_source(struct known_udp_source* ks, int ks_len)
{
int i;
for (i = 0; i < ks_len; i++)
if (!ks[i].allocated) return i;
return -1;
}
/* TODO: Make that dynamic... */
#define MAX_UDP_SRC 1024
/* Array to keep the UDP sources we have seen before */
struct known_udp_source udp_known_sources[MAX_UDP_SRC];
/* Process UDP coming from outside (client towards server) /* Process UDP coming from outside (client towards server)
* If it's a new source, probe; otherwise, forward to previous target * If it's a new source, probe; otherwise, forward to previous target
* Returns: >= 0 sockfd of newly allocated socket, for new connections * Returns: >= 0 sockfd of newly allocated socket, for new connections
* -1 otherwise * -1 otherwise
* */ * */
int udp_c2s_forward(int sockfd, cnx_collection* collection) int udp_c2s_forward(int sockfd, cnx_collection* collection, int max_fd)
{ {
char addr_str[NI_MAXHOST+1+NI_MAXSERV+1]; char addr_str[NI_MAXHOST+1+NI_MAXSERV+1];
struct sockaddr src_addr; struct sockaddr src_addr;
struct addrinfo addrinfo; struct addrinfo addrinfo;
struct known_udp_source* src; struct sslhcfg_protocols_item* proto;
struct connection* cnx;
ssize_t len; ssize_t len;
socklen_t addrlen; socklen_t addrlen;
int res, target, out = -1; int res, target, out = -1;
@ -101,88 +73,74 @@ int udp_c2s_forward(int sockfd, cnx_collection* collection)
perror("recvfrom"); perror("recvfrom");
return -1; return -1;
} }
target = known_source(udp_known_sources, ARRAY_SIZE(udp_known_sources), target = known_source(collection, max_fd, &src_addr, addrlen);
&src_addr, addrlen);
addrinfo.ai_addr = &src_addr; addrinfo.ai_addr = &src_addr;
addrinfo.ai_addrlen = addrlen; addrinfo.ai_addrlen = addrlen;
if (cfg.verbose) if (cfg.verbose)
fprintf(stderr, "received %ld UDP from %d:%s\n", len, target, sprintaddr(addr_str, sizeof(addr_str), &addrinfo)); fprintf(stderr, "received %ld UDP from %d:%s\n", len, target, sprintaddr(addr_str, sizeof(addr_str), &addrinfo));
if (target == -1) { if (target == -1) {
target = get_empty_source(udp_known_sources, ARRAY_SIZE(udp_known_sources)); res = probe_buffer(data, len, &proto);
fprintf(stderr, "source target index %d\n", target);
if (target == -1) {
fprintf(stderr, "Out of UDP structs\n");
exit(0); /* TODO handle this properly */
}
/* save this as an active connection */
src = &udp_known_sources[target];
src->allocated = 1;
src->client_addr = src_addr;
src->addrlen = addrlen;
src->local_endpoint = sockfd;
res = probe_buffer(data, len, &src->proto);
/* First version: if we can't work out the protocol from the first /* First version: if we can't work out the protocol from the first
* packet, drop it. Conceivably, we could store several packets to * packet, drop it. Conceivably, we could store several packets to
* run probes on packet sets */ * run probes on packet sets */
if (cfg.verbose) fprintf(stderr, "UDP probed: %d\n", res); if (cfg.verbose) fprintf(stderr, "UDP probed: %d\n", res);
if (res != PROBE_MATCH) { if (res != PROBE_MATCH) {
src->allocated = 0;
return -1; return -1;
} }
src->target_sock = socket(src->proto->saddr->ai_family, SOCK_DGRAM, 0); out = socket(proto->saddr->ai_family, SOCK_DGRAM, 0);
out = src->target_sock;
struct connection* cnx = collection_alloc_cnx_from_fd(collection, out); struct connection* cnx = collection_alloc_cnx_from_fd(collection, out);
if (!cnx) return -1;
target = out;
cnx->target_sock = out;
cnx->proto = proto;
cnx->type = SOCK_DGRAM; cnx->type = SOCK_DGRAM;
cnx->udp_source = &udp_known_sources[target]; cnx->client_addr = src_addr;
cnx->addrlen = addrlen;
cnx->local_endpoint = sockfd;
} }
cnx = collection_get_cnx_from_fd(collection, target);
src = &udp_known_sources[target];
/* at this point src is the UDP connection */ /* at this point src is the UDP connection */
res = sendto(src->target_sock, data, len, 0, res = sendto(cnx->target_sock, data, len, 0,
src->proto->saddr->ai_addr, src->proto->saddr->ai_addrlen); cnx->proto->saddr->ai_addr, cnx->proto->saddr->ai_addrlen);
src->last_active = time(NULL); cnx->last_active = time(NULL);
fprintf(stderr, "sending %d to %s\n", fprintf(stderr, "sending %d to %s\n",
res, sprintaddr(data, sizeof(data), src->proto->saddr)); res, sprintaddr(data, sizeof(data), cnx->proto->saddr));
return out; return out;
} }
void udp_s2c_forward(struct known_udp_source* src) void udp_s2c_forward(struct connection* cnx)
{ {
int sockfd = src->target_sock; int sockfd = cnx->target_sock;
char data[65536]; char data[65536];
int res; int res;
res = recvfrom(sockfd, data, sizeof(data), 0, NULL, NULL); res = recvfrom(sockfd, data, sizeof(data), 0, NULL, NULL);
fprintf(stderr, "recvfrom %d\n", res); fprintf(stderr, "recvfrom %d\n", res);
CHECK_RES_DIE(res, "udp_listener/recvfrom"); CHECK_RES_DIE(res, "udp_listener/recvfrom");
res = sendto(src->local_endpoint, data, res, 0, res = sendto(cnx->local_endpoint, data, res, 0,
&src->client_addr, src->addrlen); &cnx->client_addr, cnx->addrlen);
src->last_active = time(NULL); cnx->last_active = time(NULL);
fprintf(stderr, "sendto %d to\n", res); fprintf(stderr, "sendto %d to\n", res);
} }
/* Clears old connections from udp_known_sources, and from passed fd_set */ /* Checks if a connection timed out, in which case close the socket and return
* 1; otherwise return 0. */
#define UDP_TIMEOUT 60 /* Timeout before forgetting the connection, in seconds */ #define UDP_TIMEOUT 60 /* Timeout before forgetting the connection, in seconds */
int udp_timedout(struct connection* cnx) int udp_timedout(struct connection* cnx)
{ {
time_t now = time(NULL); time_t now = time(NULL);
struct known_udp_source* src = cnx->udp_source;
if (!cnx->udp_source) return 0; /* Not a UDP connection */ if (cnx->type != SOCK_DGRAM) return 0; /* Not a UDP connection */
if (src->allocated && (now - src->last_active > UDP_TIMEOUT)) { if ((now - cnx->last_active > UDP_TIMEOUT)) {
close(src->target_sock); close(cnx->target_sock);
if (cfg.verbose > 3) if (cfg.verbose > 3)
fprintf(stderr, "disconnect timed out UDP %d\n", src->target_sock); fprintf(stderr, "disconnect timed out UDP %d\n", cnx->target_sock);
memset(src, 0, sizeof(*src));
return 1; return 1;
} }
return 0; return 0;

View File

@ -14,13 +14,14 @@ void udp_listener(struct listen_endpoint* endpoint, int num_endpoints, int activ
* Returns: >= 0 sockfd of newly allocated socket, for new connections * Returns: >= 0 sockfd of newly allocated socket, for new connections
* -1 otherwise * -1 otherwise
* */ * */
int udp_c2s_forward(int sockfd, cnx_collection* collection); int udp_c2s_forward(int sockfd, cnx_collection* collection, int max_fd);
/* Process UDP coming from inside (server towards client) */ /* Process UDP coming from inside (server towards client) */
void udp_s2c_forward(struct known_udp_source* src); void udp_s2c_forward(struct connection* cnx);
/* Checks if a connection timed out, in which case clear it. */ /* Checks if a connection timed out, in which case close the socket and return
* 1; otherwise return 0. */
int udp_timedout(struct connection* cnx); int udp_timedout(struct connection* cnx);
#endif /* UDPLISTENER_H */ #endif /* UDPLISTENER_H */