Fix detekt issues.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>

subsonic-api/src/integrationTest/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIClientTest.kt

@@ -30,6 +30,7 @@ import java.util.TimeZone
 /**
  * Integration test for [SubsonicAPIClient] class.
  */
+@Suppress("TooManyFunctions")
 class SubsonicAPIClientTest {
     companion object {
         const val USERNAME = "some-user"
@@ -49,7 +50,7 @@ class SubsonicAPIClientTest {
     }
 
     @Test
-    fun `Should pass password hash and salt in query params for api version 1_13_0`() {
+    fun `Should pass password hash and salt in query params for api version 1 13 0`() {
         val clientV12 = SubsonicAPIClient(mockWebServerRule.mockWebServer.url("/").toString(), USERNAME,
                 PASSWORD, SubsonicAPIVersions.V1_14_0, CLIENT_ID)
         enqueueResponse("ping_ok.json")
@@ -70,7 +71,7 @@ class SubsonicAPIClientTest {
     }
 
     @Test
-    fun `Should pass  hex encoded password in query params for api version 1_12_0`() {
+    fun `Should pass  hex encoded password in query params for api version 1 12 0`() {
         val clientV11 = SubsonicAPIClient(mockWebServerRule.mockWebServer.url("/").toString(), USERNAME,
                 PASSWORD, SubsonicAPIVersions.V1_12_0, CLIENT_ID)
         enqueueResponse("ping_ok.json")
@@ -153,7 +154,7 @@ class SubsonicAPIClientTest {
 
     @Test
     fun `Should parse get indexes ok response`() {
-        // TODO: check for shortcut parsing
+        // check for shortcut parsing
         enqueueResponse("get_indexes_ok.json")
 
         val response = client.api.getIndexes(null, null).execute()
@@ -303,4 +304,4 @@ class SubsonicAPIClientTest {
         version `should be` SubsonicAPIVersions.V1_13_0
         error `should be` null
     }
-}
+}

subsonic-api/src/integrationTest/kotlin/org/moire/ultrasonic/api/subsonic/rules/MockWebServerRule.kt

@@ -24,4 +24,4 @@ class MockWebServerRule : TestRule {
         }
         return ruleStatement
     }
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIClient.kt

@@ -110,4 +110,4 @@ class SubsonicAPIClient(baseUrl: String,
             this.addQueryParameter("s", salt)
         }
     }
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIDefinition.kt

@@ -30,4 +30,4 @@ interface SubsonicAPIDefinition {
 
     @GET("getMusicDirectory.view")
     fun getMusicDirectory(@Query("id") id: Long): Call<GetMusicDirectoryResponse>
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIVersions.kt

@@ -61,4 +61,4 @@ enum class SubsonicAPIVersions(val subsonicVersions: String, val restApiVersion:
             }
         }
     }
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicError.kt

@@ -35,4 +35,4 @@ enum class SubsonicError(val code: Int) {
             }
         }
     }
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/Artist.kt

@@ -4,4 +4,4 @@ import java.util.Calendar
 
 data class Artist(val id: Long,
                   val name: String,
-                  val starred: Calendar?)
+                  val starred: Calendar?)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/Index.kt

@@ -4,4 +4,4 @@ import com.fasterxml.jackson.annotation.JsonProperty
 
 data class Index(val name: String,
                  @JsonProperty("artist")
-                 val artists: List<Artist>)
+                 val artists: List<Artist>)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/Indexes.kt

@@ -6,4 +6,4 @@ data class Indexes(val lastModified: Long,
                    val ignoredArticles: String?,
                    @JsonProperty("index")
                    val indexList: List<Index>,
-                   val shortcuts: List<Index>?)
+                   val shortcuts: List<Index>?)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/License.kt

@@ -6,4 +6,4 @@ data class License(
         val valid: Boolean = false,
         val email: String = "",
         val trialExpires: Calendar = Calendar.getInstance(),
-        val licenseExpires: Calendar = Calendar.getInstance())
+        val licenseExpires: Calendar = Calendar.getInstance())

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/MusicDirectory.kt

@@ -7,4 +7,4 @@ data class MusicDirectory(val id: Long,
                           val name: String,
                           val starred: Calendar?,
                           @JsonProperty("child")
-                          val childList: List<MusicDirectoryChild> = emptyList())
+                          val childList: List<MusicDirectoryChild> = emptyList())

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/MusicDirectoryChild.kt

@@ -6,4 +6,4 @@ data class MusicDirectoryChild(val id: Long, val parent: Long, val isDir: Boolea
                                val title: String = "", val album: String = "",
                                val artist: String = "", val year: Int?,
                                val genre: String = "", val coverArt: Long = -1,
-                               val created: Calendar, val starred: Calendar?)
+                               val created: Calendar, val starred: Calendar?)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/models/MusicFolder.kt

@@ -1,3 +1,3 @@
 package org.moire.ultrasonic.api.subsonic.models
 
-data class MusicFolder(val id: Long = -1, val name: String = "")
+data class MusicFolder(val id: Long = -1, val name: String = "")

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/response/GetIndexesResponse.kt

@@ -8,4 +8,4 @@ class GetIndexesResponse(status: Status,
                          version: SubsonicAPIVersions,
                          error: SubsonicError?,
                          val indexes: Indexes?) :
-        SubsonicResponse(status, version, error)
+        SubsonicResponse(status, version, error)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/response/GetMusicDirectoryResponse.kt

@@ -10,4 +10,4 @@ class GetMusicDirectoryResponse(status: Status,
                                 error: SubsonicError?,
                                 @JsonProperty("directory")
                                 val musicDirectory: MusicDirectory?) :
-        SubsonicResponse(status, version, error)
+        SubsonicResponse(status, version, error)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/response/LicenseResponse.kt

@@ -8,4 +8,4 @@ class LicenseResponse(val license: License = License(),
                       status: Status,
                       version: SubsonicAPIVersions,
                       error: SubsonicError?) :
-        SubsonicResponse(status, version, error)
+        SubsonicResponse(status, version, error)

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/response/MusicFoldersResponse.kt

@@ -30,4 +30,4 @@ class MusicFoldersResponse(status: Status,
             }
         }
     }
-}
+}

subsonic-api/src/main/kotlin/org/moire/ultrasonic/api/subsonic/response/SubsonicResponse.kt

@@ -36,4 +36,4 @@ open class SubsonicResponse(val status: Status,
             }
         }
     }
-}
+}

subsonic-api/src/test/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIVersionsDeserializerTest.kt

@@ -41,4 +41,4 @@ class SubsonicAPIVersionsDeserializerTest {
 
         parsedVersion `should be` SubsonicAPIVersions.V1_13_0
     }
-}
+}

subsonic-api/src/test/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicAPIVersionsTest.kt

@@ -25,4 +25,4 @@ class SubsonicAPIVersionsTest(private val apiVersion: SubsonicAPIVersions) {
     fun `Should throw IllegalArgumentException for unknown api version`() {
         SubsonicAPIVersions.fromApiVersion(apiVersion.restApiVersion.substring(0, 2))
     }
-}
+}

subsonic-api/src/test/kotlin/org/moire/ultrasonic/api/subsonic/SubsonicErrorTest.kt

@@ -25,4 +25,4 @@ class SubsonicErrorTest(private val error: SubsonicError) {
     fun `Should throw IllegalArgumentException from unknown error code`() {
         SubsonicError.parseErrorFromJson(error.code + 10000)
     }
-}
+}

subsonic-api/src/test/kotlin/org/moire/ultrasonic/api/subsonic/models/StatusTest.kt

@@ -26,4 +26,4 @@ class StatusTest(private val status: SubsonicResponse.Status) {
     fun `Should throw IllegalArgumentException on unknown status`() {
         SubsonicResponse.Status.getStatusFromJson(status.jsonValue.plus("-some"))
     }
-}
+}

ultrasonic/src/main/kotlin/org/moire/ultrasonic/data/SubsonicAPIConverter.kt

@@ -12,4 +12,4 @@ fun convertMusicFolder(entity: APIMusicFolder): MusicFolder {
 
 fun convertMusicFolderList(entitiesList: List<APIMusicFolder>): List<MusicFolder> {
     return entitiesList.map { convertMusicFolder(it) }
-}
+}

ultrasonic/src/test/kotlin/org/moire/ultrasonic/data/APIConverterTest.kt

@@ -40,4 +40,4 @@ class APIConverterTest {
 
     private fun createMusicFolder(id: Long = 0, name: String = ""): MusicFolder =
             MusicFolder(id, name)
-}
+}