From 3be480a9a2c20e04af9ab17d802f4f4987fd7578 Mon Sep 17 00:00:00 2001
From: tzugen <tzugen@riseup.net>
Date: Sat, 18 Dec 2021 18:18:18 +0100
Subject: [PATCH] Add error message to cache location picker Fixes #643

---
 .../org/moire/ultrasonic/fragment/SettingsFragment.kt    | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/fragment/SettingsFragment.kt b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/fragment/SettingsFragment.kt
index 9f3e5b79..e49a79fd 100644
--- a/ultrasonic/src/main/kotlin/org/moire/ultrasonic/fragment/SettingsFragment.kt
+++ b/ultrasonic/src/main/kotlin/org/moire/ultrasonic/fragment/SettingsFragment.kt
@@ -40,6 +40,7 @@ import org.moire.ultrasonic.provider.SearchSuggestionProvider
 import org.moire.ultrasonic.service.MediaPlayerController
 import org.moire.ultrasonic.service.RxBus
 import org.moire.ultrasonic.util.Constants
+import org.moire.ultrasonic.util.ErrorDialog
 import org.moire.ultrasonic.util.FileUtil.defaultMusicDirectory
 import org.moire.ultrasonic.util.FileUtil.ultrasonicDirectory
 import org.moire.ultrasonic.util.InfoDialog
@@ -183,8 +184,12 @@ class SettingsFragment :
         val write = (resultData.flags and Intent.FLAG_GRANT_WRITE_URI_PERMISSION) != 0
         val persist = (resultData.flags and Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION) != 0
 
-        // TODO Should we show an error?
-        if (!read || !write || !persist) return
+        if (!read || !write || !persist) {
+            ErrorDialog.Builder(context)
+                .setMessage(R.string.settings_cache_location_error)
+                .show()
+            return
+        }
 
         // The result data contains a URI for the document or directory that
         // the user selected.